webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h - Issue 1778503002: Experiment for the nack module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 1778503002: Experiment for the nack module. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

index ba0ed0e4c784251ef4fcdece0d1e39b12835ae0a..76faca0f7ebe24aa0e678abbf4d55b1a48349d61 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

@@ -219,8 +219,11 @@ class ModuleRtpRtcpImpl : public RtpRtcp {

int SetSelectiveRetransmissions(uint8_t settings) override;

// Send a Negative acknowledgment packet.

+ // TODO(philipel): Deprecate SendNACK and use SendNack instead.

int32_t SendNACK(const uint16_t* nack_list, uint16_t size) override;

+ void SendNack(const std::vector<uint16_t>& sequence_numbers) override;

// Store the sent packets, needed to answer to a negative acknowledgment

// requests.

void SetStorePacketsStatus(bool enable, uint16_t number_to_store) override;