Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: webrtc/modules/video_coding/video_coding_impl.cc

Issue 1778503002: Experiment for the nack module. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 std::unique_ptr<CriticalSectionWrapper> cs_; 68 std::unique_ptr<CriticalSectionWrapper> cs_;
69 EncodedImageCallback* callback_ GUARDED_BY(cs_); 69 EncodedImageCallback* callback_ GUARDED_BY(cs_);
70 }; 70 };
71 71
72 class VideoCodingModuleImpl : public VideoCodingModule { 72 class VideoCodingModuleImpl : public VideoCodingModule {
73 public: 73 public:
74 VideoCodingModuleImpl(Clock* clock, 74 VideoCodingModuleImpl(Clock* clock,
75 EventFactory* event_factory, 75 EventFactory* event_factory,
76 bool owns_event_factory, 76 bool owns_event_factory,
77 VideoEncoderRateObserver* encoder_rate_observer, 77 VideoEncoderRateObserver* encoder_rate_observer,
78 VCMQMSettingsCallback* qm_settings_callback) 78 VCMQMSettingsCallback* qm_settings_callback,
79 NackSender* nack_sender,
80 KeyFrameRequestSender* keyframe_request_sender)
79 : VideoCodingModule(), 81 : VideoCodingModule(),
80 sender_(clock, 82 sender_(clock,
81 &post_encode_callback_, 83 &post_encode_callback_,
82 encoder_rate_observer, 84 encoder_rate_observer,
83 qm_settings_callback), 85 qm_settings_callback),
84 receiver_(clock, event_factory), 86 receiver_(clock,
87 event_factory,
88 nack_sender,
89 keyframe_request_sender),
85 own_event_factory_(owns_event_factory ? event_factory : NULL) {} 90 own_event_factory_(owns_event_factory ? event_factory : NULL) {}
86 91
87 virtual ~VideoCodingModuleImpl() { own_event_factory_.reset(); } 92 virtual ~VideoCodingModuleImpl() { own_event_factory_.reset(); }
88 93
89 int64_t TimeUntilNextProcess() override { 94 int64_t TimeUntilNextProcess() override {
90 int64_t sender_time = sender_.TimeUntilNextProcess(); 95 int64_t sender_time = sender_.TimeUntilNextProcess();
91 int64_t receiver_time = receiver_.TimeUntilNextProcess(); 96 int64_t receiver_time = receiver_.TimeUntilNextProcess();
92 assert(sender_time >= 0); 97 assert(sender_time >= 0);
93 assert(receiver_time >= 0); 98 assert(receiver_time >= 0);
94 return VCM_MIN(sender_time, receiver_time); 99 return VCM_MIN(sender_time, receiver_time);
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 vcm::VideoSender sender_; 289 vcm::VideoSender sender_;
285 vcm::VideoReceiver receiver_; 290 vcm::VideoReceiver receiver_;
286 std::unique_ptr<EventFactory> own_event_factory_; 291 std::unique_ptr<EventFactory> own_event_factory_;
287 }; 292 };
288 } // namespace 293 } // namespace
289 294
290 void VideoCodingModule::Codec(VideoCodecType codecType, VideoCodec* codec) { 295 void VideoCodingModule::Codec(VideoCodecType codecType, VideoCodec* codec) {
291 VCMCodecDataBase::Codec(codecType, codec); 296 VCMCodecDataBase::Codec(codecType, codec);
292 } 297 }
293 298
299 // Create method for current interface, will be removed when the
300 // new jitter buffer is in place.
294 VideoCodingModule* VideoCodingModule::Create( 301 VideoCodingModule* VideoCodingModule::Create(
295 Clock* clock, 302 Clock* clock,
296 VideoEncoderRateObserver* encoder_rate_observer, 303 VideoEncoderRateObserver* encoder_rate_observer,
297 VCMQMSettingsCallback* qm_settings_callback) { 304 VCMQMSettingsCallback* qm_settings_callback) {
298 return new VideoCodingModuleImpl(clock, new EventFactoryImpl, true, 305 return VideoCodingModule::Create(clock, encoder_rate_observer,
299 encoder_rate_observer, qm_settings_callback); 306 qm_settings_callback,
307 nullptr, // NackSender
308 nullptr); // KeyframeRequestSender
300 } 309 }
301 310
311 // Create method for the new jitter buffer.
312 VideoCodingModule* VideoCodingModule::Create(
313 Clock* clock,
314 VideoEncoderRateObserver* encoder_rate_observer,
315 VCMQMSettingsCallback* qm_settings_callback,
316 NackSender* nack_sender,
317 KeyFrameRequestSender* keyframe_request_sender) {
318 return new VideoCodingModuleImpl(clock, new EventFactoryImpl, true,
319 encoder_rate_observer, qm_settings_callback,
320 nack_sender,
321 keyframe_request_sender);
322 }
323
324 // Create method for current interface, will be removed when the
325 // new jitter buffer is in place.
302 VideoCodingModule* VideoCodingModule::Create(Clock* clock, 326 VideoCodingModule* VideoCodingModule::Create(Clock* clock,
303 EventFactory* event_factory) { 327 EventFactory* event_factory) {
328 return VideoCodingModule::Create(clock, event_factory,
329 nullptr, // NackSender
330 nullptr); // KeyframeRequestSender
331 }
332
333 // Create method for the new jitter buffer.
334 VideoCodingModule* VideoCodingModule::Create(
335 Clock* clock,
336 EventFactory* event_factory,
337 NackSender* nack_sender,
338 KeyFrameRequestSender* keyframe_request_sender) {
304 assert(clock); 339 assert(clock);
305 assert(event_factory); 340 assert(event_factory);
306 return new VideoCodingModuleImpl(clock, event_factory, false, nullptr, 341 return new VideoCodingModuleImpl(clock, event_factory, false, nullptr,
307 nullptr); 342 nullptr, nack_sender,
343 keyframe_request_sender);
308 } 344 }
309 345
310 } // namespace webrtc 346 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698