Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: webrtc/modules/video_coding/nack_module.h

Issue 1778503002: Experiment for the nack module. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 17 matching lines...) Expand all
28 28
29 class NackModule : public Module { 29 class NackModule : public Module {
30 public: 30 public:
31 NackModule(Clock* clock, 31 NackModule(Clock* clock,
32 NackSender* nack_sender, 32 NackSender* nack_sender,
33 KeyFrameRequestSender* keyframe_request_sender); 33 KeyFrameRequestSender* keyframe_request_sender);
34 34
35 void OnReceivedPacket(const VCMPacket& packet); 35 void OnReceivedPacket(const VCMPacket& packet);
36 void ClearUpTo(uint16_t seq_num); 36 void ClearUpTo(uint16_t seq_num);
37 void UpdateRtt(int64_t rtt_ms); 37 void UpdateRtt(int64_t rtt_ms);
38 void Flush();
stefan-webrtc 2016/03/10 17:06:30 Can we call this Clear() instead? Flush is a bad n
philipel 2016/03/11 09:24:14 Done.
38 void Stop(); 39 void Stop();
39 40
40 // Module implementation 41 // Module implementation
41 int64_t TimeUntilNextProcess() override; 42 int64_t TimeUntilNextProcess() override;
42 void Process() override; 43 void Process() override;
43 44
44 private: 45 private:
45 // Which fields to consider when deciding which packet to nack in 46 // Which fields to consider when deciding which packet to nack in
46 // GetNackBatch. 47 // GetNackBatch.
47 enum NackFilterOptions { kSeqNumOnly, kTimeOnly, kSeqNumAndTime }; 48 enum NackFilterOptions { kSeqNumOnly, kTimeOnly, kSeqNumAndTime };
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 bool running_ GUARDED_BY(crit_); 93 bool running_ GUARDED_BY(crit_);
93 bool initialized_ GUARDED_BY(crit_); 94 bool initialized_ GUARDED_BY(crit_);
94 int64_t rtt_ms_ GUARDED_BY(crit_); 95 int64_t rtt_ms_ GUARDED_BY(crit_);
95 uint16_t last_seq_num_ GUARDED_BY(crit_); 96 uint16_t last_seq_num_ GUARDED_BY(crit_);
96 int64_t next_process_time_ms_ GUARDED_BY(crit_); 97 int64_t next_process_time_ms_ GUARDED_BY(crit_);
97 }; 98 };
98 99
99 } // namespace webrtc 100 } // namespace webrtc
100 101
101 #endif // WEBRTC_MODULES_VIDEO_CODING_NACK_MODULE_H_ 102 #endif // WEBRTC_MODULES_VIDEO_CODING_NACK_MODULE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698