Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778243006: Remove the (previosly deprecated) Pass methods (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the (previosly deprecated) Pass methods Everyone should be using std::move instead. BUG=webrtc:5373 Committed: https://crrev.com/0149e7595ecb9ca76363b45b1e807ba9f26e6a5d Cr-Commit-Position: refs/heads/master@{#11962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -43 lines) Patch
M webrtc/base/buffer.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/base/buffer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/scoped_ptr.h View 3 chunks +0 lines, -13 lines 0 comments Download
M webrtc/system_wrappers/include/scoped_vector.h View 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/system_wrappers/source/scoped_vector_unittest.cc View 4 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-11 15:03:30 UTC) #2
tommi
lgtm
4 years, 9 months ago (2016-03-11 21:31:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778243006/1
4 years, 9 months ago (2016-03-11 21:31:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 22:40:56 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 22:41:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0149e7595ecb9ca76363b45b1e807ba9f26e6a5d
Cr-Commit-Position: refs/heads/master@{#11962}

Powered by Google App Engine
This is Rietveld 408576698