Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: webrtc/api/objc/RTCStatsReport.mm

Issue 1778033002: Minor ObjC API tweaks. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/objc/RTCStatsReport.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "RTCStatsReport.h" 11 #import "RTCStatsReport.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 14
15 #import "webrtc/api/objc/RTCStatsReport+Private.h" 15 #import "webrtc/api/objc/RTCStatsReport+Private.h"
16 #import "webrtc/base/objc/NSString+StdString.h" 16 #import "webrtc/base/objc/NSString+StdString.h"
17 #import "webrtc/base/objc/RTCLogging.h" 17 #import "webrtc/base/objc/RTCLogging.h"
18 18
19 @implementation RTCStatsReport 19 @implementation RTCStatsReport
20 20
21 @synthesize timestamp = _timestamp; 21 @synthesize timestamp = _timestamp;
22 @synthesize type = _type; 22 @synthesize type = _type;
23 @synthesize statsId = _statsId; 23 @synthesize reportId = _reportId;
24 @synthesize values = _values; 24 @synthesize values = _values;
25 25
26 - (NSString *)description { 26 - (NSString *)description {
27 return [NSString stringWithFormat:@"RTCStatsReport:\n%@\n%@\n%f\n%@", 27 return [NSString stringWithFormat:@"RTCStatsReport:\n%@\n%@\n%f\n%@",
28 _statsId, 28 _reportId,
29 _type, 29 _type,
30 _timestamp, 30 _timestamp,
31 _values]; 31 _values];
32 } 32 }
33 33
34 #pragma mark - Private 34 #pragma mark - Private
35 35
36 - (instancetype)initWithNativeReport:(const webrtc::StatsReport &)nativeReport { 36 - (instancetype)initWithNativeReport:(const webrtc::StatsReport &)nativeReport {
37 if (self = [super init]) { 37 if (self = [super init]) {
38 _timestamp = nativeReport.timestamp(); 38 _timestamp = nativeReport.timestamp();
39 _type = [NSString stringForStdString:nativeReport.TypeToString()]; 39 _type = [NSString stringForStdString:nativeReport.TypeToString()];
40 _statsId = [NSString stringForStdString: 40 _reportId = [NSString stringForStdString:
41 nativeReport.id()->ToString()]; 41 nativeReport.id()->ToString()];
42 42
43 NSUInteger capacity = nativeReport.values().size(); 43 NSUInteger capacity = nativeReport.values().size();
44 NSMutableDictionary *values = 44 NSMutableDictionary *values =
45 [NSMutableDictionary dictionaryWithCapacity:capacity]; 45 [NSMutableDictionary dictionaryWithCapacity:capacity];
46 for (auto const &valuePair : nativeReport.values()) { 46 for (auto const &valuePair : nativeReport.values()) {
47 NSString *key = [NSString stringForStdString: 47 NSString *key = [NSString stringForStdString:
48 valuePair.second->display_name()]; 48 valuePair.second->display_name()];
49 NSString *value = [NSString stringForStdString: 49 NSString *value = [NSString stringForStdString:
50 valuePair.second->ToString()]; 50 valuePair.second->ToString()];
51 51
52 // Not expecting duplicate keys. 52 // Not expecting duplicate keys.
53 RTC_DCHECK(![values objectForKey:key]); 53 RTC_DCHECK(![values objectForKey:key]);
54 [values setObject:value forKey:key]; 54 [values setObject:value forKey:key];
55 } 55 }
56 _values = values; 56 _values = values;
57 } 57 }
58 return self; 58 return self;
59 } 59 }
60 60
61 @end 61 @end
OLDNEW
« no previous file with comments | « webrtc/api/objc/RTCStatsReport.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698