Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1778033002: Minor ObjC API tweaks. (Closed)

Created:
4 years, 9 months ago by tkchin_webrtc
Modified:
4 years, 9 months ago
Reviewers:
hjon_webrtc, jiayl2, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor ObjC API tweaks. Adds setConfiguration back and renames statsId back to reportId. BUG= Committed: https://crrev.com/aac3eb2bba13b4aa3fefada9f3b28787fc26d780 Cr-Commit-Position: refs/heads/master@{#11936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M talk/build/build_ios_libs.sh View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCPeerConnection.h View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCPeerConnection.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCStatsReport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCStatsReport.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
tkchin_webrtc
4 years, 9 months ago (2016-03-09 19:55:27 UTC) #3
Chuck
lgtm
4 years, 9 months ago (2016-03-09 21:47:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778033002/1
4 years, 9 months ago (2016-03-09 21:48:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4018)
4 years, 9 months ago (2016-03-09 21:55:10 UTC) #8
tkchin_webrtc
@jiayl mind rubber stamping? I don't own build_ios_libs.sh.
4 years, 9 months ago (2016-03-09 21:59:34 UTC) #10
hjon_webrtc
On 2016/03/09 19:55:27, tkchin_webrtc wrote: lgtm
4 years, 9 months ago (2016-03-09 22:00:20 UTC) #11
jiayl2
lgtm
4 years, 9 months ago (2016-03-09 22:10:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778033002/1
4 years, 9 months ago (2016-03-09 22:54:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/11571)
4 years, 9 months ago (2016-03-09 23:49:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778033002/1
4 years, 9 months ago (2016-03-10 00:02:57 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11586)
4 years, 9 months ago (2016-03-10 02:21:24 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778033002/1
4 years, 9 months ago (2016-03-10 04:52:36 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 05:49:45 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 05:49:58 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aac3eb2bba13b4aa3fefada9f3b28787fc26d780
Cr-Commit-Position: refs/heads/master@{#11936}

Powered by Google App Engine
This is Rietveld 408576698