Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1777273002: Reland of VideoCapturerAndroid: Use one thread per startCapture()/stopCapture() session (Closed)

Created:
4 years, 9 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of VideoCapturerAndroid: Use one thread per startCapture()/stopCapture() session: https://codereview.webrtc.org/1763673002/ This reland includes a fix for the cameraObserver bug. BUG=webrtc:5519 ,b/27497950 TBR=perkj@webrtc.org Committed: https://crrev.com/a97e3cfe49201595767b474beebbd676d14ae575 Cr-Commit-Position: refs/heads/master@{#11943}

Patch Set 1 : Pure revert #

Patch Set 2 : Fix cameraObserver bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -68 lines) Patch
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 17 chunks +103 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777273002/40001
4 years, 9 months ago (2016-03-10 12:44:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-10 14:53:57 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a97e3cfe49201595767b474beebbd676d14ae575 Cr-Commit-Position: refs/heads/master@{#11943}
4 years, 9 months ago (2016-03-10 14:54:08 UTC) #9
perkj_webrtc
4 years, 9 months ago (2016-03-10 15:17:18 UTC) #10
Message was sent while issue was closed.
lgtm

For me to see cls with TBR  you have to press the publish button. otherwise the
reviewer  is not copied to the Reviewers list.  ... A small bug in the system..

Powered by Google App Engine
This is Rietveld 408576698