Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1777253002: Revert of VideoCapturerAndroid: Use one thread per startCapture()/stopCapture() session (Closed)

Created:
4 years, 9 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of VideoCapturerAndroid: Use one thread per startCapture()/stopCapture() session (patchset #2 id:60001 of https://codereview.webrtc.org/1763673002/ ) Reason for revert: Frame rate and freeze detection not working properly after switchCamera(). This is because the previous cameraObserver is not removed before posting a new one. Original issue's description: > VideoCapturerAndroid: Use one thread per startCapture()/stopCapture() session > > Currently, VideoCapturerAndroid sets the thread and handler in the ctor > and clears them in dispose(). This CL sets the handler in startCapture() > instead and clears it in stopCapture(). The purpose is to prepare for > sending in the SurfaceTextureHelper in startCapture() instead of letting > VideoCapturerAndroid create it in the ctor. > > All access to the handler is now synchronized by a lock, and all > Runnables are posted with a token so that they can be removed all at > once in stopCapture() to guarantee that no pending operation will be > executed after stopCapture(). > > BUG=webrtc:5519 > > Committed: https://crrev.com/9cbebee523dbd280a4f67ad414a432ed730f241f > Cr-Commit-Position: refs/heads/master@{#11939} TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5519 Committed: https://crrev.com/430a9c3bfde108063df2756a98e5ab59094234ed Cr-Commit-Position: refs/heads/master@{#11941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -107 lines) Patch
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 17 chunks +73 lines, -107 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_webrtc
Created Revert of VideoCapturerAndroid: Use one thread per startCapture()/stopCapture() session
4 years, 9 months ago (2016-03-10 12:30:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777253002/1
4 years, 9 months ago (2016-03-10 12:30:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 12:30:33 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 12:30:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/430a9c3bfde108063df2756a98e5ab59094234ed
Cr-Commit-Position: refs/heads/master@{#11941}

Powered by Google App Engine
This is Rietveld 408576698