Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1776363002: Use ProcessReverseStream in VoiceEngines OutputMixer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@reverse2
Patch Set: Take the lock in the right place Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index fd08c8e9817cfaf846e40ee84caec570a6a4b8a6..0ef6f19d69d38cd52d33fb52928f45932a426b3b 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -442,12 +442,6 @@ void AudioProcessingImpl::SetExtraOptions(const Config& config) {
#endif // WEBRTC_ANDROID_PLATFORM_BUILD
}
-int AudioProcessingImpl::input_sample_rate_hz() const {
- // Accessed from outside APM, hence a lock is needed.
- rtc::CritScope cs(&crit_capture_);
- return formats_.api_format.input_stream().sample_rate_hz();
-}
-
int AudioProcessingImpl::proc_sample_rate_hz() const {
// Used as callback from submodules, hence locking is not allowed.
return capture_nonlocked_.fwd_proc_format.sample_rate_hz();
@@ -840,8 +834,8 @@ int AudioProcessingImpl::AnalyzeReverseStreamLocked(
int AudioProcessingImpl::ProcessReverseStream(AudioFrame* frame) {
TRACE_EVENT0("webrtc", "AudioProcessing::ProcessReverseStream_AudioFrame");
- RETURN_ON_ERR(AnalyzeReverseStream(frame));
rtc::CritScope cs(&crit_render_);
+ RETURN_ON_ERR(AnalyzeReverseStream(frame));
if (is_rev_processed()) {
render_.render_audio->InterleaveTo(frame, true);
}
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.h ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698