Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 1776363002: Use ProcessReverseStream in VoiceEngines OutputMixer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@reverse2
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 95e56097da3df12139076f52e906fc23c87d3ec4..2890bd5dcd31dbcd59feb06b85f6a59c047b3855 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -296,10 +296,6 @@ class AudioProcessing {
// ensures the options are applied immediately.
virtual void SetExtraOptions(const Config& config) = 0;
- // TODO(peah): Remove after voice engine no longer requires it to resample
- // the reverse stream to the forward rate.
- virtual int input_sample_rate_hz() const = 0;
-
// TODO(ajm): Only intended for internal use. Make private and friend the
// necessary classes?
virtual int proc_sample_rate_hz() const = 0;
@@ -367,8 +363,7 @@ class AudioProcessing {
// chances are you don't need to use it.
//
// The |sample_rate_hz_|, |num_channels_|, and |samples_per_channel_|
- // members of |frame| must be valid. |sample_rate_hz_| must correspond to
- // |input_sample_rate_hz()|
+ // members of |frame| must be valid.
//
// TODO(ajm): add const to input; requires an implementation fix.
// DEPRECATED: Use |ProcessReverseStream| instead.
the sun 2016/03/10 12:49:22 If this is deprecated, can we make it a thin wrapp
aluebs-webrtc 2016/03/10 16:33:17 Actually, now that we are updating the VoE, we can

Powered by Google App Engine
This is Rietveld 408576698