webrtc/modules/audio_processing/audio_processing_impl.cc - Issue 1776363002: Use ProcessReverseStream in VoiceEngines OutputMixer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1776363002: Use ProcessReverseStream in VoiceEngines OutputMixer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@reverse2

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.h ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | webrtc/modules/audio_processing/include/audio_processing.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/audio_processing_impl.cc

diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc

index fd08c8e9817cfaf846e40ee84caec570a6a4b8a6..7dd3578213196739de596c634ab54a45a898cf4f 100644

--- a/webrtc/modules/audio_processing/audio_processing_impl.cc

+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc

@@ -442,12 +442,6 @@ void AudioProcessingImpl::SetExtraOptions(const Config& config) {

#endif // WEBRTC_ANDROID_PLATFORM_BUILD

}

-int AudioProcessingImpl::input_sample_rate_hz() const {

- // Accessed from outside APM, hence a lock is needed.

- rtc::CritScope cs(&crit_capture_);

- return formats_.api_format.input_stream().sample_rate_hz();

int AudioProcessingImpl::proc_sample_rate_hz() const {

// Used as callback from submodules, hence locking is not allowed.

return capture_nonlocked_.fwd_proc_format.sample_rate_hz();