Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 1776243003: Revert of - Clean up unused voice engine DTMF code. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@voe_dtmf_1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of - Clean up unused voice engine DTMF code. (patchset #4 id:60001 of https://codereview.webrtc.org/1722253002/ ) Reason for revert: Breaks Chromium FYI bots for Android. E.g. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28K%20Nexus5%29/builds/4486/steps/content_browsertests/logs/stdio Original issue's description: > - Clean up unused voice engine DTMF code following removal of VoEDtmf APIs. > - Use better types in AudioSendStream::SendTelephoneEvent() and related methods. > > BUG=webrtc:4690 > > Committed: https://crrev.com/8886c816582a7c6190c5429222cb8096fca302a6 > Cr-Commit-Position: refs/heads/master@{#11927} TBR=tina.legrand@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Committed: https://crrev.com/3ecb5c869842ddfccab35e3111a8e415a47e2b5b Cr-Commit-Position: refs/heads/master@{#11930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -43 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio_send_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 5 chunks +20 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 10 chunks +113 lines, -17 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/voice_engine/dtmf_inband.h View 1 chunk +0 lines, -3 lines 0 comments Download
A webrtc/voice_engine/dtmf_inband_queue.h View 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/voice_engine/dtmf_inband_queue.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
the sun
Created Revert of - Clean up unused voice engine DTMF code.
4 years, 9 months ago (2016-03-09 15:31:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776243003/1
4 years, 9 months ago (2016-03-09 15:31:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 15:32:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3ecb5c869842ddfccab35e3111a8e415a47e2b5b Cr-Commit-Position: refs/heads/master@{#11930}
4 years, 9 months ago (2016-03-09 15:32:09 UTC) #6
hlundin-webrtc
4 years, 9 months ago (2016-03-09 15:34:15 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698