Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by hbos Modified:
4 years, 9 months ago Reviewers:
hta-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded webrtc/base/safe_conversions.h as a pseudonym
for webrtc/base/numerics/safe_conversions.h.
This prevents downstream projects from breaking that have not yet been
updated to use the new file path. As soon as they have this file should
be removed.
This is a follow-up to https://codereview.webrtc.org/1753293002/.
TBR=hta@webrtc.org
NOPRESUBMIT=True
NOTRY=True
BUG=webrtc:5548
Committed: https://crrev.com/b8f78858619c676955e1098ecc24f2612e55c84f
Cr-Commit-Position: refs/heads/master@{#11912}
Patch Set 1 : #
Created: 4 years, 9 months ago
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. BUG=webrtc:5548, webrtc:5623 ========== to ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. BUG=webrtc:5548 ==========
Patchset #1 (id:1) has been deleted
hbos@webrtc.org changed reviewers: + hta@webrtc.org
Please take a look, hta
Description was changed from ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. BUG=webrtc:5548 ========== to ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOTRY=True BUG=webrtc:5548 ==========
Description was changed from ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOTRY=True BUG=webrtc:5548 ========== to ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOPRESUBMIT=True NOTRY=True BUG=webrtc:5548 ==========
The CQ bit was checked by hbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774933003/20001
Message was sent while issue was closed.
Description was changed from ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOPRESUBMIT=True NOTRY=True BUG=webrtc:5548 ========== to ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOPRESUBMIT=True NOTRY=True BUG=webrtc:5548 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOPRESUBMIT=True NOTRY=True BUG=webrtc:5548 ========== to ========== Added webrtc/base/safe_conversions.h as a pseudonym for webrtc/base/numerics/safe_conversions.h. This prevents downstream projects from breaking that have not yet been updated to use the new file path. As soon as they have this file should be removed. This is a follow-up to https://codereview.webrtc.org/1753293002/. TBR=hta@webrtc.org NOPRESUBMIT=True NOTRY=True BUG=webrtc:5548 Committed: https://crrev.com/b8f78858619c676955e1098ecc24f2612e55c84f Cr-Commit-Position: refs/heads/master@{#11912} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b8f78858619c676955e1098ecc24f2612e55c84f Cr-Commit-Position: refs/heads/master@{#11912}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.webrtc.org/1789853003/ by tommi@chromium.org. The reason for reverting is: Looks like the Chrome iOS build is broken because of these two changes. So I'm going to have to revert. Here's the error: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_n... FAILED: rm -f arch/libsafe_numerics.arm64.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.arm64.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] FAILED: rm -f arch/libsafe_numerics.armv7.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.armv7.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] ninja: build stopped: subcommand failed..
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.webrtc.org/1787953002/ by tommi@webrtc.org. The reason for reverting is: Looks like the Chrome iOS build is broken because of these two changes. So I'm going to have to revert. Here's the error: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_n... FAILED: rm -f arch/libsafe_numerics.arm64.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.arm64.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] FAILED: rm -f arch/libsafe_numerics.armv7.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.armv7.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] ninja: build stopped: subcommand failed.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
