Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: webrtc/base/opensslstreamadapter.h

Issue 1774583002: Add IsAcceptableCipher, use instead of GetDefaultCipher. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/opensslstreamadapter.h
diff --git a/webrtc/base/opensslstreamadapter.h b/webrtc/base/opensslstreamadapter.h
index e57b2a3293d5942ae15226a778ed39907f965db8..3157b5266f27788260e1d06a6fa85454dfac9eec 100644
--- a/webrtc/base/opensslstreamadapter.h
+++ b/webrtc/base/opensslstreamadapter.h
@@ -92,6 +92,8 @@ class OpenSSLStreamAdapter : public SSLStreamAdapter {
bool GetSslCipherSuite(int* cipher) override;
+ int GetSslVersion() const override;
+
// Key Extractor interface
bool ExportKeyingMaterial(const std::string& label,
const uint8_t* context,
@@ -109,9 +111,8 @@ class OpenSSLStreamAdapter : public SSLStreamAdapter {
static bool HaveDtlsSrtp();
static bool HaveExporter();
- // TODO(guoweis): Move this away from a static class method.
- static int GetDefaultSslCipherForTest(SSLProtocolVersion version,
- KeyType key_type);
+ static bool IsAcceptableCipher(int cipher, KeyType key_type);
+ static bool IsAcceptableCipher(std::string cipher, KeyType key_type);
tommi 2016/03/10 21:37:59 const &
torbjorng (webrtc) 2016/03/11 07:50:18 Done.
protected:
void OnEvent(StreamInterface* stream, int events, int err) override;

Powered by Google App Engine
This is Rietveld 408576698