Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1774343002: Filter out the network in networkmonitor if the linkProperties is null. (Closed)

Created:
4 years, 9 months ago by honghaiz3
Modified:
4 years, 9 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, jiayl2
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Filter out the network in networkmonitor if the linkProperties is null. It may be null if the network is unknown. Also revised the logging to replace network id with network.toString(). They are pretty much the same for logging but network.toString does not need to parse the int value. BUG= Committed: https://crrev.com/97aacee11d21caa4ca9c40c493aeba6940a7c063 Cr-Commit-Position: refs/heads/master@{#11925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
honghaiz3
4 years, 9 months ago (2016-03-09 01:43:33 UTC) #3
AlexG
lgtm
4 years, 9 months ago (2016-03-09 03:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774343002/1
4 years, 9 months ago (2016-03-09 03:37:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 04:50:03 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 04:50:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97aacee11d21caa4ca9c40c493aeba6940a7c063
Cr-Commit-Position: refs/heads/master@{#11925}

Powered by Google App Engine
This is Rietveld 408576698