Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1774123003: Fixed incorrect handling of timestamps in video quality test (Closed)

Created:
4 years, 9 months ago by sprang_webrtc
Modified:
4 years, 9 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed incorrect handling of timestamps in video quality test * Both timestamps must be unwrapped before comparing * rtp timestamp delta must be subtracted before unwrapping BUG=webrtc:5637, webrtc:5537 Committed: https://crrev.com/16daaa5a407e0b7c6918ee0974d1b00c5a7f0db3 Cr-Commit-Position: refs/heads/master@{#11926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M webrtc/video/video_quality_test.cc View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sprang_webrtc
4 years, 9 months ago (2016-03-08 14:39:14 UTC) #2
pbos-webrtc
lgtm
4 years, 9 months ago (2016-03-08 22:40:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774123003/1
4 years, 9 months ago (2016-03-09 08:42:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 09:30:28 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 09:41:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16daaa5a407e0b7c6918ee0974d1b00c5a7f0db3
Cr-Commit-Position: refs/heads/master@{#11926}

Powered by Google App Engine
This is Rietveld 408576698