Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: webrtc/api/objc/RTCPeerConnection+Stats.mm

Issue 1773743002: Restore type attributes and remove extraneous nullability annotations for Objective-C Mac build (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/objc/RTCPeerConnection.h ('k') | webrtc/api/objc/RTCStatsReport.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "webrtc/api/objc/RTCPeerConnection+Private.h" 11 #import "webrtc/api/objc/RTCPeerConnection+Private.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 14
15 #import "webrtc/api/objc/RTCMediaStreamTrack+Private.h" 15 #import "webrtc/api/objc/RTCMediaStreamTrack+Private.h"
16 #import "webrtc/api/objc/RTCStatsReport+Private.h" 16 #import "webrtc/api/objc/RTCStatsReport+Private.h"
17 #import "webrtc/base/objc/NSString+StdString.h" 17 #import "webrtc/base/objc/NSString+StdString.h"
18 18
19 // TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
20
21 namespace webrtc { 19 namespace webrtc {
22 20
23 class StatsObserverAdapter : public StatsObserver { 21 class StatsObserverAdapter : public StatsObserver {
24 public: 22 public:
25 StatsObserverAdapter(void (^completionHandler) 23 StatsObserverAdapter(void (^completionHandler)
26 (NSArray *stats)) { 24 (NSArray<RTCStatsReport *> *stats)) {
27 // (NSArray<RTCStatsReport *> *stats)) {
28 completion_handler_ = completionHandler; 25 completion_handler_ = completionHandler;
29 } 26 }
30 27
31 ~StatsObserverAdapter() { 28 ~StatsObserverAdapter() {
32 completion_handler_ = nil; 29 completion_handler_ = nil;
33 } 30 }
34 31
35 void OnComplete(const StatsReports& reports) override { 32 void OnComplete(const StatsReports& reports) override {
36 RTC_DCHECK(completion_handler_); 33 RTC_DCHECK(completion_handler_);
37 NSMutableArray *stats = [NSMutableArray arrayWithCapacity:reports.size()]; 34 NSMutableArray *stats = [NSMutableArray arrayWithCapacity:reports.size()];
38 for (const auto* report : reports) { 35 for (const auto* report : reports) {
39 RTCStatsReport *statsReport = 36 RTCStatsReport *statsReport =
40 [[RTCStatsReport alloc] initWithNativeReport:*report]; 37 [[RTCStatsReport alloc] initWithNativeReport:*report];
41 [stats addObject:statsReport]; 38 [stats addObject:statsReport];
42 } 39 }
43 completion_handler_(stats); 40 completion_handler_(stats);
44 completion_handler_ = nil; 41 completion_handler_ = nil;
45 } 42 }
46 43
47 private: 44 private:
48 void (^completion_handler_)(NSArray *stats); 45 void (^completion_handler_)(NSArray<RTCStatsReport *> *stats);
49 // void (^completion_handler_)(NSArray<RTCStatsReport *> *stats);
50 }; 46 };
51 } // namespace webrtc 47 } // namespace webrtc
52 48
53 @implementation RTCPeerConnection (Stats) 49 @implementation RTCPeerConnection (Stats)
54 50
55 - (void)statsForTrack:(RTCMediaStreamTrack *)mediaStreamTrack 51 - (void)statsForTrack:(RTCMediaStreamTrack *)mediaStreamTrack
56 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel 52 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
57 completionHandler: 53 completionHandler:
58 (void (^)(NSArray *stats))completionHandler { 54 (void (^)(NSArray<RTCStatsReport *> *stats))completionHandler {
59 // (void (^)(NSArray<RTCStatsReport *> *stats))completionHandler {
60 rtc::scoped_refptr<webrtc::StatsObserverAdapter> observer( 55 rtc::scoped_refptr<webrtc::StatsObserverAdapter> observer(
61 new rtc::RefCountedObject<webrtc::StatsObserverAdapter> 56 new rtc::RefCountedObject<webrtc::StatsObserverAdapter>
62 (completionHandler)); 57 (completionHandler));
63 webrtc::PeerConnectionInterface::StatsOutputLevel nativeOutputLevel = 58 webrtc::PeerConnectionInterface::StatsOutputLevel nativeOutputLevel =
64 [[self class] nativeStatsOutputLevelForLevel:statsOutputLevel]; 59 [[self class] nativeStatsOutputLevelForLevel:statsOutputLevel];
65 self.nativePeerConnection->GetStats( 60 self.nativePeerConnection->GetStats(
66 observer, mediaStreamTrack.nativeTrack, nativeOutputLevel); 61 observer, mediaStreamTrack.nativeTrack, nativeOutputLevel);
67 } 62 }
68 63
69 @end 64 @end
OLDNEW
« no previous file with comments | « webrtc/api/objc/RTCPeerConnection.h ('k') | webrtc/api/objc/RTCStatsReport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698