webrtc/modules/audio_processing/audio_processing_impl.h - Issue 1773173002: Dont always downsample to 16kHz in the reverse stream in APM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.h

Issue 1773173002: Dont always downsample to 16kHz in the reverse stream in APM (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@aecm

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « data/audio_processing/output_data_float.pb ('k') | webrtc/modules/audio_processing/audio_processing_impl.cc » ('j') | webrtc/modules/audio_processing/audio_processing_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/audio_processing_impl.h

diff --git a/webrtc/modules/audio_processing/audio_processing_impl.h b/webrtc/modules/audio_processing/audio_processing_impl.h

index 560920b1e19a63006b23645edb029d5542c96743..2772da3be3a3444aa5e6ea9ddc76ee317425b7ef 100644

--- a/webrtc/modules/audio_processing/audio_processing_impl.h

+++ b/webrtc/modules/audio_processing/audio_processing_impl.h

@@ -204,13 +204,10 @@ class AudioProcessingImpl : public AudioProcessing {

// Capture-side exclusive methods possibly running APM in a multi-threaded

// manner that are called with the render lock already acquired.

int ProcessStreamLocked() EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

- bool output_copy_needed(bool is_data_processed) const

- EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

+ bool output_copy_needed() const EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

bool is_data_processed() const EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

- bool synthesis_needed(bool is_data_processed) const

- EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

- bool analysis_needed(bool is_data_processed) const

- EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

+ bool synthesis_needed() const EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

+ bool analysis_needed() const EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

void MaybeUpdateHistograms() EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

// Render-side exclusive methods possibly running APM in a multi-threaded

@@ -221,6 +218,8 @@ class AudioProcessingImpl : public AudioProcessing {

const StreamConfig& output_config)

EXCLUSIVE_LOCKS_REQUIRED(crit_render_);

bool is_rev_processed() const EXCLUSIVE_LOCKS_REQUIRED(crit_render_);

+ bool rev_synthesis_needed() const EXCLUSIVE_LOCKS_REQUIRED(crit_render_);

+ bool rev_analysis_needed() const EXCLUSIVE_LOCKS_REQUIRED(crit_render_);

int ProcessReverseStreamLocked() EXCLUSIVE_LOCKS_REQUIRED(crit_render_);

// Debug dump methods that are internal and called without locks.