Delete VAD methods from AcmReceiver and move functionality inside NetEq

Delete VAD methods from AcmReceiver and move functionality inside NetEq

This change essentially does two things:

1. Remove the VAD-related methods from AcmReceiver. These are
EnableVad(), DisableVad(), and vad_enabled(). None of them were used
outside of unit tests.

2. Move the functionality to set AudioFrame::speech_type_ and
AudioFrame::vad_activity_ inside NetEq. This was previously done in
AcmReceiver, but based on information inherently owned by NetEq.

With the change in 2, NetEq's GetAudio interface can be simplified by
removing the output type parameter. This will be done in a follow-up
CL.

BUG=webrtc:5607
Committed: https://crrev.com/500c04bc86ab3ad10b4bd0eca3f0a39487bd1913
Cr-Commit-Position: refs/heads/master@{#11902}

[hlundin-webrtc, 2016-03-07 09:27:52]

henrik.lundin@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2016-03-08 09:27:07]

lgtm

https://codereview.webrtc.org/1772583002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/1772583002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:192: }
}  // namespace

[hlundin-webrtc, 2016-03-08 09:32:06]

The CQ bit was checked by henrik.lundin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 09:32:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772583002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772583002/1

[hlundin-webrtc, 2016-03-08 10:11:17]

https://codereview.webrtc.org/1772583002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/1772583002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:192: }
On 2016/03/08 09:27:07, kwiberg-webrtc wrote:
> }  // namespace

Acknowledged. Will be fixed in a follow-up, to save precious try-bot cycles.

[kwiberg-webrtc, 2016-03-08 10:16:30]

https://codereview.webrtc.org/1772583002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/1772583002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:192: }
On 2016/03/08 10:11:17, hlundin-webrtc wrote:
> On 2016/03/08 09:27:07, kwiberg-webrtc wrote:
> > }  // namespace
> 
> Acknowledged. Will be fixed in a follow-up, to save precious try-bot cycles.

My precioussss...

[commit-bot: I haz the power, 2016-03-08 10:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 10:29:21]

Dry run: This issue passed the CQ dry run.

[hlundin-webrtc, 2016-03-08 10:30:32]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-03-08 10:30:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772583002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772583002/1

[commit-bot: I haz the power, 2016-03-08 10:36:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-08 10:36:13]

Description was changed from

==========
Delete VAD methods from AcmReceiver and move functionality inside NetEq

This change essentially does two things:

1. Remove the VAD-related methods from AcmReceiver. These are
EnableVad(), DisableVad(), and vad_enabled(). None of them were used
outside of unit tests.

2. Move the functionality to set AudioFrame::speech_type_ and
AudioFrame::vad_activity_ inside NetEq. This was previously done in
AcmReceiver, but based on information inherently owned by NetEq.

With the change in 2, NetEq's GetAudio interface can be simplified by
removing the output type parameter. This will be done in a follow-up
CL.

BUG=webrtc:5607
==========

to

==========
Delete VAD methods from AcmReceiver and move functionality inside NetEq

This change essentially does two things:

1. Remove the VAD-related methods from AcmReceiver. These are
EnableVad(), DisableVad(), and vad_enabled(). None of them were used
outside of unit tests.

2. Move the functionality to set AudioFrame::speech_type_ and
AudioFrame::vad_activity_ inside NetEq. This was previously done in
AcmReceiver, but based on information inherently owned by NetEq.

With the change in 2, NetEq's GetAudio interface can be simplified by
removing the output type parameter. This will be done in a follow-up
CL.

BUG=webrtc:5607

Committed: https://crrev.com/500c04bc86ab3ad10b4bd0eca3f0a39487bd1913
Cr-Commit-Position: refs/heads/master@{#11902}
==========

[commit-bot: I haz the power, 2016-03-08 10:36:13]

Patchset 1 (id:??) landed as
https://crrev.com/500c04bc86ab3ad10b4bd0eca3f0a39487bd1913
Cr-Commit-Position: refs/heads/master@{#11902}