Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1772553002: Removed the ProcessingComponent class (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@RemoveComponentFromAGC_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed the ProcessingComponent class BUG= Committed: https://crrev.com/737f4b8d12a44909814f8f481579a2e88adc834e Cr-Commit-Position: refs/heads/master@{#11950}

Patch Set 1 : Removed the ProcessingComponent class #

Total comments: 2

Patch Set 2 : Changed file name of the queue verifier #

Total comments: 4

Patch Set 3 : Corrected build files to use the correct header file name #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Fixed changed include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -215 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 2 3 6 chunks +0 lines, -27 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_processing/processing_component.h View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/modules/audio_processing/processing_component.cc View 1 chunk +0 lines, -111 lines 0 comments Download
A webrtc/modules/audio_processing/render_queue_item_verifier.h View 1 1 chunk +36 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (11 generated)
peah-webrtc
4 years, 9 months ago (2016-03-07 07:03:14 UTC) #3
hlundin-webrtc
On 2016/03/07 07:03:14, peah-webrtc wrote: Drive-by yay! :)
4 years, 9 months ago (2016-03-07 08:43:04 UTC) #4
the sun
https://codereview.webrtc.org/1772553002/diff/20001/webrtc/modules/audio_processing/render_queues_verifier.h File webrtc/modules/audio_processing/render_queues_verifier.h (right): https://codereview.webrtc.org/1772553002/diff/20001/webrtc/modules/audio_processing/render_queues_verifier.h#newcode11 webrtc/modules/audio_processing/render_queues_verifier.h:11: #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_RENDER_QUEUES_VERIFIER_H_ Rename this file render_queue_item_verifier (as per the ...
4 years, 9 months ago (2016-03-07 15:00:52 UTC) #5
peah-webrtc
https://codereview.webrtc.org/1772553002/diff/20001/webrtc/modules/audio_processing/render_queues_verifier.h File webrtc/modules/audio_processing/render_queues_verifier.h (right): https://codereview.webrtc.org/1772553002/diff/20001/webrtc/modules/audio_processing/render_queues_verifier.h#newcode11 webrtc/modules/audio_processing/render_queues_verifier.h:11: #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_RENDER_QUEUES_VERIFIER_H_ On 2016/03/07 15:00:52, the sun wrote: > ...
4 years, 9 months ago (2016-03-08 08:03:11 UTC) #6
peah-webrtc
4 years, 9 months ago (2016-03-08 08:20:47 UTC) #7
the sun
https://codereview.webrtc.org/1772553002/diff/40001/webrtc/modules/audio_processing/BUILD.gn File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/1772553002/diff/40001/webrtc/modules/audio_processing/BUILD.gn#newcode89 webrtc/modules/audio_processing/BUILD.gn:89: "render_queues_verifier.h", did you try compiling? :) https://codereview.webrtc.org/1772553002/diff/40001/webrtc/modules/audio_processing/audio_processing.gypi File webrtc/modules/audio_processing/audio_processing.gypi ...
4 years, 9 months ago (2016-03-09 09:45:47 UTC) #8
peah-webrtc
https://codereview.webrtc.org/1772553002/diff/40001/webrtc/modules/audio_processing/BUILD.gn File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/1772553002/diff/40001/webrtc/modules/audio_processing/BUILD.gn#newcode89 webrtc/modules/audio_processing/BUILD.gn:89: "render_queues_verifier.h", On 2016/03/09 09:45:47, the sun wrote: > did ...
4 years, 9 months ago (2016-03-09 10:22:52 UTC) #9
the sun
lgtm
4 years, 9 months ago (2016-03-09 11:39:46 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 1768943002 Patch 140001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-11 04:33:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772553002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772553002/100001
4 years, 9 months ago (2016-03-11 05:26:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/9587) linux_compile_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 9 months ago (2016-03-11 05:28:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772553002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772553002/120001
4 years, 9 months ago (2016-03-11 05:56:57 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 9 months ago (2016-03-11 07:05:32 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 07:05:47 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/737f4b8d12a44909814f8f481579a2e88adc834e
Cr-Commit-Position: refs/heads/master@{#11950}

Powered by Google App Engine
This is Rietveld 408576698