webrtc/modules/audio_processing/audio_processing_impl.h - Issue 1772453002: Removing dependency of the EchoControlMobileImpl class on ProcessingComponent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.h

Issue 1772453002: Removing dependency of the EchoControlMobileImpl class on ProcessingComponent. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changes in response to reviewer comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_processing/audio_processing_impl.h

diff --git a/webrtc/modules/audio_processing/audio_processing_impl.h b/webrtc/modules/audio_processing/audio_processing_impl.h

index 560920b1e19a63006b23645edb029d5542c96743..d79d34c8bcb34bda9cb1af0226f7e9f73b048137 100644

--- a/webrtc/modules/audio_processing/audio_processing_impl.h

+++ b/webrtc/modules/audio_processing/audio_processing_impl.h

@@ -198,6 +198,8 @@ class AudioProcessingImpl : public AudioProcessing {

EXCLUSIVE_LOCKS_REQUIRED(crit_capture_);

void InitializeEchoCanceller()

EXCLUSIVE_LOCKS_REQUIRED(crit_render_, crit_capture_);

+ void InitializeEchoControlMobile()

+ EXCLUSIVE_LOCKS_REQUIRED(crit_render_, crit_capture_);

int InitializeLocked(const ProcessingConfig& config)

EXCLUSIVE_LOCKS_REQUIRED(crit_render_, crit_capture_);

« no previous file with comments | « no previous file | webrtc/modules/audio_processing/audio_processing_impl.cc » ('j') | webrtc/modules/audio_processing/echo_control_mobile_impl.cc » ('J')