Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webrtc/modules/video_coding/frame_object.h

Issue 1772383002: Packet buffer for the new jitter buffer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/frame_object.h
diff --git a/webrtc/modules/video_coding/frame_object.h b/webrtc/modules/video_coding/frame_object.h
new file mode 100644
index 0000000000000000000000000000000000000000..2a68293d638332ee8799e79201e53de2732bbd8b
--- /dev/null
+++ b/webrtc/modules/video_coding/frame_object.h
@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
+#define WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
+
+#include "webrtc/modules/video_coding/packet.h"
+
+namespace webrtc {
+namespace video_coding {
+
+class FrameObject {
+ public:
+ virtual uint16_t picture_id() const = 0;
+ virtual bool GetBitstream(uint8_t* destination) const = 0;
+ virtual ~FrameObject() {}
+};
+
+class PacketBuffer;
+
+class RtpFrameObject : public FrameObject {
+ public:
+ RtpFrameObject(PacketBuffer* packet_buffer,
+ uint16_t picture_id,
+ uint16_t first_packet,
+ uint16_t last_packet);
+ ~RtpFrameObject();
+ uint16_t first_packet() const;
+ uint16_t last_packet() const;
+ uint16_t picture_id() const override;
+ bool GetBitstream(uint8_t* destination) const override;
+
+ private:
+ PacketBuffer* packet_buffer_;
stefan-webrtc 2016/03/30 11:59:31 I think this can be const?
philipel 2016/03/30 12:40:11 Can't be const. The ReturnFrame function is non co
+ uint16_t picture_id_;
+ uint16_t first_packet_;
+ uint16_t last_packet_;
+};
+
+} // namespace video_coding
+} // namespace webrtc
+
+#endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_

Powered by Google App Engine
This is Rietveld 408576698