Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Issue 1772383002: Packet buffer for the new jitter buffer. (Closed)

Created:
4 years, 9 months ago by philipel
Modified:
4 years, 8 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Packet buffer for the new jitter buffer. BUG=webrtc:5514 R=stefan@webrtc.org, mflodman@webrtc.org

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Generalized the FrameObject class. #

Total comments: 26

Patch Set 4 : Feedback fixes. #

Total comments: 4

Patch Set 5 : Feedback fixes #

Total comments: 24

Patch Set 6 : Feedback fixes #

Total comments: 2

Patch Set 7 : Moved comment and ClearUpTo() now clears packets immediately. #

Total comments: 4

Patch Set 8 : Update cleared_to_seq_num_ when FrameObjects are returned #

Total comments: 6

Patch Set 9 : Last comment fixes #

Patch Set 10 : Rebase #

Patch Set 11 : Added frame_object.h/cc to BUILD.gn. #

Patch Set 12 : More parenthesis for the buildbots! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -0 lines) Patch
M webrtc/modules/modules.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/frame_object.h View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/frame_object.cc View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/packet_buffer.h View 1 2 3 4 5 6 7 8 1 chunk +81 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/packet_buffer.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +204 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/packet_buffer_unittest.cc View 1 2 3 4 5 6 7 1 chunk +305 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 42 (15 generated)
philipel
The FrameObject class is currently rather minimal and will be extended as needed as I ...
4 years, 9 months ago (2016-03-08 15:33:47 UTC) #1
philipel
Put the FrameObject class in frame_object.h/cc instead of packet_buffer.h/cc. Again, the FrameObject class is rather ...
4 years, 9 months ago (2016-03-10 13:06:02 UTC) #2
philipel
ping
4 years, 9 months ago (2016-03-17 10:46:58 UTC) #3
stefan-webrtc
A first set of comments. https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc File webrtc/modules/video_coding/frame_object.cc (right): https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc#newcode27 webrtc/modules/video_coding/frame_object.cc:27: int index = first_packet_ ...
4 years, 9 months ago (2016-03-17 12:06:31 UTC) #4
philipel
https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc File webrtc/modules/video_coding/frame_object.cc (right): https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc#newcode27 webrtc/modules/video_coding/frame_object.cc:27: int index = first_packet_ % packet_buffer_->size_; On 2016/03/17 12:06:31, ...
4 years, 9 months ago (2016-03-17 15:00:36 UTC) #5
philipel
ping...
4 years, 9 months ago (2016-03-23 12:47:07 UTC) #6
stefan-webrtc
https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc File webrtc/modules/video_coding/frame_object.cc (right): https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc#newcode27 webrtc/modules/video_coding/frame_object.cc:27: int index = first_packet_ % packet_buffer_->size_; On 2016/03/17 15:00:35, ...
4 years, 9 months ago (2016-03-24 09:41:21 UTC) #7
philipel
https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc File webrtc/modules/video_coding/frame_object.cc (right): https://codereview.webrtc.org/1772383002/diff/40001/webrtc/modules/video_coding/frame_object.cc#newcode27 webrtc/modules/video_coding/frame_object.cc:27: int index = first_packet_ % packet_buffer_->size_; On 2016/03/24 09:41:21, ...
4 years, 8 months ago (2016-03-30 09:44:54 UTC) #8
stefan-webrtc
LG, just a few more comments to address. https://codereview.webrtc.org/1772383002/diff/80001/webrtc/modules/video_coding/frame_object.h File webrtc/modules/video_coding/frame_object.h (right): https://codereview.webrtc.org/1772383002/diff/80001/webrtc/modules/video_coding/frame_object.h#newcode41 webrtc/modules/video_coding/frame_object.h:41: PacketBuffer* ...
4 years, 8 months ago (2016-03-30 11:59:32 UTC) #9
philipel
https://codereview.webrtc.org/1772383002/diff/80001/webrtc/modules/video_coding/frame_object.h File webrtc/modules/video_coding/frame_object.h (right): https://codereview.webrtc.org/1772383002/diff/80001/webrtc/modules/video_coding/frame_object.h#newcode41 webrtc/modules/video_coding/frame_object.h:41: PacketBuffer* packet_buffer_; On 2016/03/30 11:59:31, stefan-webrtc (holmer) wrote: > ...
4 years, 8 months ago (2016-03-30 12:40:11 UTC) #10
stefan-webrtc
https://codereview.webrtc.org/1772383002/diff/80001/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/1772383002/diff/80001/webrtc/modules/video_coding/packet_buffer.cc#newcode77 webrtc/modules/video_coding/packet_buffer.cc:77: clear_up_to_ = seq_num; On 2016/03/30 12:40:11, philipel wrote: > ...
4 years, 8 months ago (2016-03-30 12:56:20 UTC) #11
philipel
https://codereview.webrtc.org/1772383002/diff/100001/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/1772383002/diff/100001/webrtc/modules/video_coding/packet_buffer.cc#newcode23 webrtc/modules/video_coding/packet_buffer.cc:23: // Both |start_buffer_size| and |max_buffer_size| must be a power ...
4 years, 8 months ago (2016-03-30 13:35:52 UTC) #12
stefan-webrtc
https://codereview.webrtc.org/1772383002/diff/120001/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/1772383002/diff/120001/webrtc/modules/video_coding/packet_buffer.cc#newcode52 webrtc/modules/video_coding/packet_buffer.cc:52: return false; Maybe we should treat this as a ...
4 years, 8 months ago (2016-03-30 13:47:36 UTC) #13
philipel
https://codereview.webrtc.org/1772383002/diff/120001/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/1772383002/diff/120001/webrtc/modules/video_coding/packet_buffer.cc#newcode52 webrtc/modules/video_coding/packet_buffer.cc:52: return false; On 2016/03/30 13:47:35, stefan-webrtc (holmer) wrote: > ...
4 years, 8 months ago (2016-03-31 12:21:51 UTC) #14
stefan-webrtc
lgtm, but consider my last comments before committing. https://codereview.webrtc.org/1772383002/diff/140001/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/1772383002/diff/140001/webrtc/modules/video_coding/packet_buffer.cc#newcode46 webrtc/modules/video_coding/packet_buffer.cc:46: cleared_to_seq_num_ ...
4 years, 8 months ago (2016-03-31 13:03:01 UTC) #15
philipel
https://codereview.webrtc.org/1772383002/diff/140001/webrtc/modules/video_coding/packet_buffer.cc File webrtc/modules/video_coding/packet_buffer.cc (right): https://codereview.webrtc.org/1772383002/diff/140001/webrtc/modules/video_coding/packet_buffer.cc#newcode46 webrtc/modules/video_coding/packet_buffer.cc:46: cleared_to_seq_num_ = seq_num - 1; On 2016/03/31 13:03:00, stefan-webrtc ...
4 years, 8 months ago (2016-03-31 14:09:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772383002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772383002/160001
4 years, 8 months ago (2016-03-31 14:09:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/2842) android_gn_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-03-31 14:10:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772383002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772383002/180001
4 years, 8 months ago (2016-03-31 14:24:22 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: mac_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/1996)
4 years, 8 months ago (2016-03-31 14:26:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772383002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772383002/200001
4 years, 8 months ago (2016-03-31 14:44:42 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/2847) android_gn_rel on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-03-31 14:47:28 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772383002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772383002/220001
4 years, 8 months ago (2016-03-31 14:58:38 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-03-31 16:59:21 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772383002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772383002/220001
4 years, 8 months ago (2016-04-01 08:28:46 UTC) #38
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/c707ab7cb0d087b7db33a1b2d65a5a9ff631f3ad Cr-Commit-Position: refs/heads/master@{#12194}
4 years, 8 months ago (2016-04-01 09:02:06 UTC) #40
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 09:02:10 UTC) #42
Message was sent while issue was closed.
Committed patchset #12 (id:220001)

Powered by Google App Engine
This is Rietveld 408576698