Revert of Implement the NackModule as part of the new jitter buffer.

Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall: https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/builds/6362

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
>
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
>
> BUG=webrtc:5514
>
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc.org,perkj@webrtc.org,tommi@webrtc.org,philipel@webrtc.org
BUG=webrtc:5514
NOTRY=True

Committed: https://crrev.com/eb648bf0e5a9bae185bcd6b4b3be371e1da3507d
Cr-Commit-Position: refs/heads/master@{#11887}

[kjellander_webrtc, 2016-03-07 17:31:28]

Created Revert of Implement the NackModule as part of the new jitter buffer.

[kjellander_webrtc, 2016-03-07 17:32:13]

Description was changed from

==========
Revert of Implement the NackModule as part of the new jitter buffer. (patchset
#19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/build...

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on
the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
> 
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
> 
> BUG=webrtc:5514
> 
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc....
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5514
==========

to

==========
Revert of Implement the NackModule as part of the new jitter buffer. (patchset
#19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/build...

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on
the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
> 
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
> 
> BUG=webrtc:5514
> 
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc....
BUG=webrtc:5514
NOTRY=True
==========

[kjellander_webrtc, 2016-03-07 17:55:05]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-03-07 17:55:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771883002/1

[commit-bot: I haz the power, 2016-03-07 17:56:29]

Description was changed from

==========
Revert of Implement the NackModule as part of the new jitter buffer. (patchset
#19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/build...

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on
the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
> 
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
> 
> BUG=webrtc:5514
> 
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc....
BUG=webrtc:5514
NOTRY=True
==========

to

==========
Revert of Implement the NackModule as part of the new jitter buffer. (patchset
#19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/build...

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on
the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
> 
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
> 
> BUG=webrtc:5514
> 
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc....
BUG=webrtc:5514
NOTRY=True
==========

[commit-bot: I haz the power, 2016-03-07 17:56:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-07 17:56:36]

Description was changed from

==========
Revert of Implement the NackModule as part of the new jitter buffer. (patchset
#19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/build...

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on
the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
> 
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
> 
> BUG=webrtc:5514
> 
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc....
BUG=webrtc:5514
NOTRY=True
==========

to

==========
Revert of Implement the NackModule as part of the new jitter buffer. (patchset
#19 id:360001 of https://codereview.webrtc.org/1715673002/ )

Reason for revert:
Unfortunately this breaks in the main waterfall:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/build...

I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on
the trybots, but not on the bots in the main waterfall.

Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
>
> Things done/implemented in this CL:
>   - An interface that can send Nack (VCMNackSender).
>   - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
>   - The nack module (NackModule).
>   - A set of convenience functions for modular numbers (mod_ops.h).
>
> BUG=webrtc:5514
>
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}

TBR=sprang@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,torbjorng@webrtc....
BUG=webrtc:5514
NOTRY=True

Committed: https://crrev.com/eb648bf0e5a9bae185bcd6b4b3be371e1da3507d
Cr-Commit-Position: refs/heads/master@{#11887}
==========

[commit-bot: I haz the power, 2016-03-07 17:56:37]

Patchset 1 (id:??) landed as
https://crrev.com/eb648bf0e5a9bae185bcd6b4b3be371e1da3507d
Cr-Commit-Position: refs/heads/master@{#11887}