Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 1771383002: Filter out network-change event with a null interface name. (Closed)

Created:
4 years, 9 months ago by honghaiz3
Modified:
4 years, 9 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Filter out network-change event with a null interface name. This fixes an Android native crash. This has happened occasionally. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/13e433902da05539319f4609d02ac44631e0796c Cr-Commit-Position: refs/heads/master@{#11919}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 3 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
honghaiz3
This will fix a recent ApprtcDemo crash where the OS reported an Address change with ...
4 years, 9 months ago (2016-03-08 17:07:14 UTC) #2
AlexG
lgtm
4 years, 9 months ago (2016-03-08 19:34:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771383002/20001
4 years, 9 months ago (2016-03-08 19:42:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13e433902da05539319f4609d02ac44631e0796c Cr-Commit-Position: refs/heads/master@{#11919}
4 years, 9 months ago (2016-03-08 21:10:26 UTC) #9
honghaiz3
4 years, 9 months ago (2016-03-08 21:10:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
13e433902da05539319f4609d02ac44631e0796c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698