Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 1770823002: Removed the AudioProcessing dependency in EchoCancellerImpl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@CleanUpAecImpl_CL
Patch Set: Rebase from latest master Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/echo_cancellation_impl.h
diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.h b/webrtc/modules/audio_processing/echo_cancellation_impl.h
index dccef332a359acdd945459fcd4ead7dc0425b07c..f196bcab3a10884af7ff4f2b57e4b17361fdb21f 100644
--- a/webrtc/modules/audio_processing/echo_cancellation_impl.h
+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.h
@@ -25,13 +25,12 @@ class AudioBuffer;
class EchoCancellationImpl : public EchoCancellation {
public:
- EchoCancellationImpl(const AudioProcessing* apm,
- rtc::CriticalSection* crit_render,
+ EchoCancellationImpl(rtc::CriticalSection* crit_render,
rtc::CriticalSection* crit_capture);
virtual ~EchoCancellationImpl();
int ProcessRenderAudio(const AudioBuffer* audio);
- int ProcessCaptureAudio(AudioBuffer* audio);
+ int ProcessCaptureAudio(AudioBuffer* audio, int stream_delay_ms);
// EchoCancellation implementation.
bool is_enabled() const override;
@@ -39,7 +38,10 @@ class EchoCancellationImpl : public EchoCancellation {
SuppressionLevel suppression_level() const override;
bool is_drift_compensation_enabled() const override;
- void Initialize();
+ void Initialize(int sample_rate_hz,
+ size_t num_reverse_channels_,
+ size_t num_output_channels_,
+ size_t num_proc_channels_);
void SetExtraOptions(const Config& config);
bool is_delay_agnostic_enabled() const;
bool is_extended_filter_enabled() const;
@@ -54,6 +56,7 @@ class EchoCancellationImpl : public EchoCancellation {
private:
class Canceller;
+ struct StreamProperties;
// EchoCancellation implementation.
int Enable(bool enable) override;
@@ -73,14 +76,11 @@ class EchoCancellationImpl : public EchoCancellation {
struct AecCore* aec_core() const override;
- size_t num_handles_required() const;
+ size_t NumCancellersRequired() const;
void AllocateRenderQueue();
int Configure();
- // Not guarded as its public API is thread safe.
- const AudioProcessing* apm_;
-
rtc::CriticalSection* const crit_render_ ACQUIRED_BEFORE(crit_capture_);
rtc::CriticalSection* const crit_capture_;
@@ -106,6 +106,8 @@ class EchoCancellationImpl : public EchoCancellation {
render_signal_queue_;
std::vector<std::unique_ptr<Canceller>> cancellers_;
+ std::unique_ptr<StreamProperties> stream_properties_;
+
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(EchoCancellationImpl);
};
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/echo_cancellation_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698