Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 1770823002: Removed the AudioProcessing dependency in EchoCancellerImpl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@CleanUpAecImpl_CL
Patch Set: Changed the way the error checks were done Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 13 matching lines...) Expand all
24 class AudioBuffer; 24 class AudioBuffer;
25 25
26 class EchoCancellationImpl : public EchoCancellation { 26 class EchoCancellationImpl : public EchoCancellation {
27 public: 27 public:
28 EchoCancellationImpl(const AudioProcessing* apm, 28 EchoCancellationImpl(const AudioProcessing* apm,
29 rtc::CriticalSection* crit_render, 29 rtc::CriticalSection* crit_render,
30 rtc::CriticalSection* crit_capture); 30 rtc::CriticalSection* crit_capture);
31 virtual ~EchoCancellationImpl(); 31 virtual ~EchoCancellationImpl();
32 32
33 int ProcessRenderAudio(const AudioBuffer* audio); 33 int ProcessRenderAudio(const AudioBuffer* audio);
34 int ProcessCaptureAudio(AudioBuffer* audio); 34 int ProcessCaptureAudio(AudioBuffer* audio, int stream_delay_ms);
35 35
36 // EchoCancellation implementation. 36 // EchoCancellation implementation.
37 bool is_enabled() const override; 37 bool is_enabled() const override;
38 int stream_drift_samples() const override; 38 int stream_drift_samples() const override;
39 SuppressionLevel suppression_level() const override; 39 SuppressionLevel suppression_level() const override;
40 bool is_drift_compensation_enabled() const override; 40 bool is_drift_compensation_enabled() const override;
41 41
42 void Initialize(); 42 void Initialize();
43 void Initialize(int sample_rate_hz,
44 size_t num_reverse_channels_,
45 size_t num_output_channels_,
46 size_t num_proc_channels_);
43 void SetExtraOptions(const Config& config); 47 void SetExtraOptions(const Config& config);
44 bool is_delay_agnostic_enabled() const; 48 bool is_delay_agnostic_enabled() const;
45 bool is_extended_filter_enabled() const; 49 bool is_extended_filter_enabled() const;
46 bool is_next_generation_aec_enabled() const; 50 bool is_next_generation_aec_enabled() const;
47 51
48 // Reads render side data that has been queued on the render call. 52 // Reads render side data that has been queued on the render call.
49 // Called holding the capture lock. 53 // Called holding the capture lock.
50 void ReadQueuedRenderData(); 54 void ReadQueuedRenderData();
51 55
52 // Returns the system delay of the first AEC component. 56 // Returns the system delay of the first AEC component.
53 int GetSystemDelayInSamples() const; 57 int GetSystemDelayInSamples() const;
54 58
55 private: 59 private:
56 class Canceller; 60 class Canceller;
61 struct StreamProperties;
57 62
58 // EchoCancellation implementation. 63 // EchoCancellation implementation.
59 int Enable(bool enable) override; 64 int Enable(bool enable) override;
60 int enable_drift_compensation(bool enable) override; 65 int enable_drift_compensation(bool enable) override;
61 void set_stream_drift_samples(int drift) override; 66 void set_stream_drift_samples(int drift) override;
62 int set_suppression_level(SuppressionLevel level) override; 67 int set_suppression_level(SuppressionLevel level) override;
63 int enable_metrics(bool enable) override; 68 int enable_metrics(bool enable) override;
64 bool are_metrics_enabled() const override; 69 bool are_metrics_enabled() const override;
65 bool stream_has_echo() const override; 70 bool stream_has_echo() const override;
66 int GetMetrics(Metrics* metrics) override; 71 int GetMetrics(Metrics* metrics) override;
67 int enable_delay_logging(bool enable) override; 72 int enable_delay_logging(bool enable) override;
68 bool is_delay_logging_enabled() const override; 73 bool is_delay_logging_enabled() const override;
69 int GetDelayMetrics(int* median, int* std) override; 74 int GetDelayMetrics(int* median, int* std) override;
70 int GetDelayMetrics(int* median, 75 int GetDelayMetrics(int* median,
71 int* std, 76 int* std,
72 float* fraction_poor_delays) override; 77 float* fraction_poor_delays) override;
73 78
74 struct AecCore* aec_core() const override; 79 struct AecCore* aec_core() const override;
75 80
76 size_t num_handles_required() const; 81 size_t NumCancellersRequired() const;
77 82
78 void AllocateRenderQueue(); 83 void AllocateRenderQueue();
79 int Configure(); 84 int Configure();
80 85
81 // Not guarded as its public API is thread safe. 86 // Not guarded as its public API is thread safe.
82 const AudioProcessing* apm_; 87 const AudioProcessing* apm_;
88 size_t num_reverse_channels_;
89 size_t num_output_channels_;
90 size_t num_proc_channels_;
83 91
84 rtc::CriticalSection* const crit_render_ ACQUIRED_BEFORE(crit_capture_); 92 rtc::CriticalSection* const crit_render_ ACQUIRED_BEFORE(crit_capture_);
85 rtc::CriticalSection* const crit_capture_; 93 rtc::CriticalSection* const crit_capture_;
86 94
87 bool enabled_ = false; 95 bool enabled_ = false;
88 bool drift_compensation_enabled_ GUARDED_BY(crit_capture_); 96 bool drift_compensation_enabled_ GUARDED_BY(crit_capture_);
89 bool metrics_enabled_ GUARDED_BY(crit_capture_); 97 bool metrics_enabled_ GUARDED_BY(crit_capture_);
90 SuppressionLevel suppression_level_ GUARDED_BY(crit_capture_); 98 SuppressionLevel suppression_level_ GUARDED_BY(crit_capture_);
91 int stream_drift_samples_ GUARDED_BY(crit_capture_); 99 int stream_drift_samples_ GUARDED_BY(crit_capture_);
92 bool was_stream_drift_set_ GUARDED_BY(crit_capture_); 100 bool was_stream_drift_set_ GUARDED_BY(crit_capture_);
93 bool stream_has_echo_ GUARDED_BY(crit_capture_); 101 bool stream_has_echo_ GUARDED_BY(crit_capture_);
94 bool delay_logging_enabled_ GUARDED_BY(crit_capture_); 102 bool delay_logging_enabled_ GUARDED_BY(crit_capture_);
95 bool extended_filter_enabled_ GUARDED_BY(crit_capture_); 103 bool extended_filter_enabled_ GUARDED_BY(crit_capture_);
96 bool delay_agnostic_enabled_ GUARDED_BY(crit_capture_); 104 bool delay_agnostic_enabled_ GUARDED_BY(crit_capture_);
97 bool next_generation_aec_enabled_ GUARDED_BY(crit_capture_); 105 bool next_generation_aec_enabled_ GUARDED_BY(crit_capture_);
98 106
99 size_t render_queue_element_max_size_ GUARDED_BY(crit_render_) 107 size_t render_queue_element_max_size_ GUARDED_BY(crit_render_)
100 GUARDED_BY(crit_capture_); 108 GUARDED_BY(crit_capture_);
101 std::vector<float> render_queue_buffer_ GUARDED_BY(crit_render_); 109 std::vector<float> render_queue_buffer_ GUARDED_BY(crit_render_);
102 std::vector<float> capture_queue_buffer_ GUARDED_BY(crit_capture_); 110 std::vector<float> capture_queue_buffer_ GUARDED_BY(crit_capture_);
103 111
104 // Lock protection not needed. 112 // Lock protection not needed.
105 std::unique_ptr<SwapQueue<std::vector<float>, RenderQueueItemVerifier<float>>> 113 std::unique_ptr<SwapQueue<std::vector<float>, RenderQueueItemVerifier<float>>>
106 render_signal_queue_; 114 render_signal_queue_;
107 115
108 std::vector<std::unique_ptr<Canceller>> cancellers_; 116 std::vector<std::unique_ptr<Canceller>> cancellers_;
117 std::unique_ptr<StreamProperties> stream_properties_;
118
109 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(EchoCancellationImpl); 119 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(EchoCancellationImpl);
110 }; 120 };
111 121
112 } // namespace webrtc 122 } // namespace webrtc
113 123
114 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_ 124 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698