Android VideoCapturerAndroid: Move stopListening() call to stopCaptureOnCameraThread()

Android VideoCapturerAndroid: Move stopListening() call to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519
,b/27497950
R=perkj@webrtc.org

Committed: https://crrev.com/1ae6a459868917c8c2bb3cc8080192abc4f4bbb2
Cr-Commit-Position: refs/heads/master@{#11917}

[magjed_webrtc, 2016-03-08 15:22:00]

Description was changed from

==========
Android VideoCapturerAndroid: Move SurfaceTextureHelper.stopListening() from
stopCapture() to stopCaptureOnCameraThread()

In switchCamera(), we only call stopCaptureOnCameraThread() not
stopCapture(), so the stopListening() call must be placed there.

The call to SurfaceTextureHelper.startListening() throws an exception
when stopListening() has not been called previously, but that exception
is swallowed by the try-reopening-the-camera-3-times logic. That's why
the tests don't fail. The call to onCameraSwitchDone() should probably
be placed at the same place as onCapturerStarted(), not immediately
after the call to switchCameraOnCameraThread() which might fail and try
to reopen the camera. I will address that in a follow-up CL.

BUG=webrtc:5519,b/27497950
==========

to

==========
Android VideoCapturerAndroid: Move SurfaceTextureHelper.stopListening() from
stopCapture() to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

The call to SurfaceTextureHelper.startListening() throws an exception
when stopListening() has not been called previously, but that exception
is swallowed by the try-reopening-the-camera-3-times logic. That's why
the tests don't fail. The call to onCameraSwitchDone() should probably
be placed at the same place as onCapturerStarted(), not immediately
after the call to switchCameraOnCameraThread() which might fail and try
to reopen the camera. I will address this issue in a follow-up CL so the
tests will catch similar issues in the future.

BUG=webrtc:5519,b/27497950
==========

[magjed_webrtc, 2016-03-08 15:23:23]

Description was changed from

==========
Android VideoCapturerAndroid: Move SurfaceTextureHelper.stopListening() from
stopCapture() to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

The call to SurfaceTextureHelper.startListening() throws an exception
when stopListening() has not been called previously, but that exception
is swallowed by the try-reopening-the-camera-3-times logic. That's why
the tests don't fail. The call to onCameraSwitchDone() should probably
be placed at the same place as onCapturerStarted(), not immediately
after the call to switchCameraOnCameraThread() which might fail and try
to reopen the camera. I will address this issue in a follow-up CL so the
tests will catch similar issues in the future.

BUG=webrtc:5519,b/27497950
==========

to

==========
Android VideoCapturerAndroid: Move SurfaceTextureHelper.stopListening() from
stopCapture() to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
==========

[magjed_webrtc, 2016-03-08 15:23:42]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2016-03-08 15:24:24]

Description was changed from

==========
Android VideoCapturerAndroid: Move SurfaceTextureHelper.stopListening() from
stopCapture() to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
==========

to

==========
Android VideoCapturerAndroid: Move 
stopListening() call to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
==========

[magjed_webrtc, 2016-03-08 15:24:32]

Description was changed from

==========
Android VideoCapturerAndroid: Move 
stopListening() call to stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
==========

to

==========
Android VideoCapturerAndroid: Move stopListening() call to
stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
==========

[magjed_webrtc, 2016-03-08 15:24:48]

perkj - Please take a look.

[perkj_webrtc, 2016-03-08 16:25:03]

On 2016/03/08 15:24:48, magjed_webrtc wrote:
> perkj - Please take a look.

a of course.... 

lgtm

[perkj_webrtc, 2016-03-08 16:26:52]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-03-08 16:27:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770423002/1

[commit-bot: I haz the power, 2016-03-08 17:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 17:20:37]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[magjed_webrtc, 2016-03-08 19:38:18]

Description was changed from

==========
Android VideoCapturerAndroid: Move stopListening() call to
stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
==========

to

==========
Android VideoCapturerAndroid: Move stopListening() call to
stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1ae6a459868917c8c2bb3cc80...
==========

[magjed_webrtc, 2016-03-08 19:38:19]

Committed patchset #1 (id:1) manually as
1ae6a459868917c8c2bb3cc8080192abc4f4bbb2 (presubmit successful).

[commit-bot: I haz the power, 2016-03-08 19:38:22]

Description was changed from

==========
Android VideoCapturerAndroid: Move stopListening() call to
stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1ae6a459868917c8c2bb3cc80...
==========

to

==========
Android VideoCapturerAndroid: Move stopListening() call to
stopCaptureOnCameraThread()

switchCamera() only calls stopCaptureOnCameraThread(), not
stopCapture(), so the stopListening() call must be placed there.

BUG=webrtc:5519,b/27497950
R=perkj@webrtc.org

Committed: https://crrev.com/1ae6a459868917c8c2bb3cc8080192abc4f4bbb2
Cr-Commit-Position: refs/heads/master@{#11917}
==========

[commit-bot: I haz the power, 2016-03-08 19:38:23]

Patchset 1 (id:??) landed as
https://crrev.com/1ae6a459868917c8c2bb3cc8080192abc4f4bbb2
Cr-Commit-Position: refs/heads/master@{#11917}