Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1770003002: Renamed VideoSourceInterface to VideoTrackSourceInterface. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renamed VideoSourceInterface to VideoTrackSourceInterface. Moved VideoSourceInterface to MediaStreamInterface.h Renamed VideoSourceTest to VideoCapturerTrackSourceTest Renamed VideoSource to VideoCaptureTrackSource and cl lint and cl format. BUG=webrtc:5426 TBR=pthatcher@webrtc.org Committed: https://crrev.com/a3ede6c5107a6d232ee115114a4130bfd0adac0c Cr-Commit-Position: refs/heads/master@{#11893}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixed Mac and IOS #

Patch Set 4 : Rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+750 lines, -881 lines) Patch
M talk/app/webrtc/objc/RTCAVFoundationVideoSource.mm View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionFactory.mm View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCVideoSource.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCVideoSource+Internal.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCVideoTrack.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/api.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/api_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M webrtc/api/mediastreaminterface.h View 3 chunks +25 lines, -7 lines 0 comments Download
M webrtc/api/mediastreamtrackproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCAVFoundationVideoSource.mm View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/api/objc/RTCVideoSource.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/objc/RTCVideoSource+Private.h View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/api/objc/RTCVideoTrack.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnection.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnectionfactory.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectionfactoryproxy.h View 1 1 chunk +7 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/rtpsender.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/videocapturertracksource.h View 1 2 3 1 chunk +84 lines, -3 lines 1 comment Download
M webrtc/api/videocapturertracksource.cc View 1 2 3 2 chunks +433 lines, -3 lines 0 comments Download
A + webrtc/api/videocapturertracksource_unittest.cc View 24 chunks +98 lines, -114 lines 0 comments Download
M webrtc/api/videosource.h View 1 1 chunk +1 line, -90 lines 0 comments Download
D webrtc/api/videosource_unittest.cc View 1 chunk +0 lines, -529 lines 0 comments Download
M webrtc/api/videosourceinterface.h View 1 chunk +1 line, -31 lines 0 comments Download
M webrtc/api/videosourceproxy.h View 1 chunk +16 lines, -14 lines 0 comments Download
M webrtc/api/videotrack.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/api/videotrack.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/videotrack_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
perkj_webrtc
Please? This is meant to be a rename only.
4 years, 9 months ago (2016-03-07 21:05:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770003002/80001
4 years, 9 months ago (2016-03-08 00:07:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3949)
4 years, 9 months ago (2016-03-08 00:16:56 UTC) #9
perkj_webrtc
Committed patchset #4 (id:80001) manually as a3ede6c5107a6d232ee115114a4130bfd0adac0c.
4 years, 9 months ago (2016-03-08 00:28:09 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a3ede6c5107a6d232ee115114a4130bfd0adac0c Cr-Commit-Position: refs/heads/master@{#11893}
4 years, 9 months ago (2016-03-08 00:28:13 UTC) #13
pthatcher1
4 years, 9 months ago (2016-03-09 20:47:15 UTC) #14
Message was sent while issue was closed. 
lgtm

https://codereview.webrtc.org/1770003002/diff/80001/webrtc/api/videocapturert...
File webrtc/api/videocapturertracksource.h (right):

https://codereview.webrtc.org/1770003002/diff/80001/webrtc/api/videocapturert...
webrtc/api/videocapturertracksource.h:29: // that honors the constraints.
make sure => make sure

Powered by Google App Engine
This is Rietveld 408576698