Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1769343003: Fix mistake in dummy videotracksource.cc and h (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix mistake in dummy videotracksource.cc and h VideoTrackSource will be implemented in an upcoming cl but is needed to be included in libjingle.gyp in Chrome before the cl can be landed. R=kjellander@webrtc.org Committed: https://crrev.com/745b297b27e189e091779eb93363dac1e980f775 Cr-Commit-Position: refs/heads/master@{#11897}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added to api.gyp. Fixed nit... #

Total comments: 1

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/api.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/videotracksource.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videotracksource.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
perkj_webrtc
please
4 years, 9 months ago (2016-03-08 01:43:57 UTC) #2
kjellander_webrtc
Please add all 4 files to GYP and GN already, to be sure it compiles ...
4 years, 9 months ago (2016-03-08 01:47:37 UTC) #3
kjellander_webrtc
https://codereview.webrtc.org/1769343003/diff/20001/webrtc/api/api.gyp File webrtc/api/api.gyp (right): https://codereview.webrtc.org/1769343003/diff/20001/webrtc/api/api.gyp#newcode316 webrtc/api/api.gyp:316: 'videotracksource.cc', Sort alphabetically
4 years, 9 months ago (2016-03-08 01:52:07 UTC) #4
kjellander_webrtc
lgtm
4 years, 9 months ago (2016-03-08 01:53:24 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/745b297b27e189e091779eb93363dac1e980f775 Cr-Commit-Position: refs/heads/master@{#11897}
4 years, 9 months ago (2016-03-08 01:55:18 UTC) #9
perkj_webrtc
4 years, 9 months ago (2016-03-08 01:55:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
745b297b27e189e091779eb93363dac1e980f775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698