Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1769113003: Revert "Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:36000… (Closed)

Created:
4 years, 9 months ago by philipel
Modified:
4 years, 9 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )" This reverts commit eb648bf0e5a9bae185bcd6b4b3be371e1da3507d. Re-reverting to fix original CL (https://codereview.webrtc.org/1715673002/). TBR=stefan@webrtc.org, tommi@webrtc.org, torbjorng@webrtc.org BUG=webrtc:5514 Committed: https://crrev.com/5ab4c6d7e0ee58b4a8cd03171aa270a49473151c Cr-Commit-Position: refs/heads/master@{#11904}

Patch Set 1 #

Patch Set 2 : Histogram DCHECK fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1157 lines, -0 lines) Patch
M webrtc/base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/base/mod_ops.h View 1 chunk +123 lines, -0 lines 0 comments Download
A webrtc/base/mod_ops_unittest.cc View 1 chunk +172 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/histogram.h View 1 chunk +46 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/histogram.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/histogram_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 3 chunks +20 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/nack_module.h View 1 chunk +101 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/nack_module.cc View 1 chunk +257 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/nack_module_unittest.cc View 1 chunk +292 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769113003/20001
4 years, 9 months ago (2016-03-08 10:11:40 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 11:36:20 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 11:36:28 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ab4c6d7e0ee58b4a8cd03171aa270a49473151c
Cr-Commit-Position: refs/heads/master@{#11904}

Powered by Google App Engine
This is Rietveld 408576698