Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1767043002: Minor cleaning up of the EchoCancellationImpl code (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor cleaning up of the EchoCancellationImpl code BUG= Committed: https://crrev.com/4510bbd5fcdbb27a7ee86d30ff3ee938dedf95b9 Cr-Commit-Position: refs/heads/master@{#11899}

Patch Set 1 #

Patch Set 2 : Rebase from latest master #

Patch Set 3 : Fixed bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 1 2 14 chunks +28 lines, -32 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
peah-webrtc
4 years, 9 months ago (2016-03-07 07:42:26 UTC) #3
hlundin-webrtc
lgtm
4 years, 9 months ago (2016-03-07 14:57:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767043002/40001
4 years, 9 months ago (2016-03-08 05:00:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/8090) ios_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 9 months ago (2016-03-08 05:01:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767043002/60001
4 years, 9 months ago (2016-03-08 05:53:30 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 9 months ago (2016-03-08 06:50:20 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 06:50:31 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4510bbd5fcdbb27a7ee86d30ff3ee938dedf95b9
Cr-Commit-Position: refs/heads/master@{#11899}

Powered by Google App Engine
This is Rietveld 408576698