Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: webrtc/media/base/videocapturer.h

Issue 1766653002: Replace SetCapturer and SetCaptureDevice by SetSource. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Delete GetVideoCapturer(!) and address other nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/base/videocapturer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videocapturer.h
diff --git a/webrtc/media/base/videocapturer.h b/webrtc/media/base/videocapturer.h
index ac2bee2b3092b85534dfd0dc2416cbfd12df5f7a..26e758e6cd6fcaea0eba5419564383bc8a0d819c 100644
--- a/webrtc/media/base/videocapturer.h
+++ b/webrtc/media/base/videocapturer.h
@@ -218,10 +218,6 @@ class VideoCapturer : public sigslot::has_slots<>,
// Takes ownership.
void set_frame_factory(VideoFrameFactory* frame_factory);
- // TODO(nisse): Rename function? Or pass the frame format before
- // adaptation in some other way.
- void GetStats(VideoFormat* last_captured_frame_format);
-
// Implements VideoSourceInterface
void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
const rtc::VideoSinkWants& wants) override;
@@ -289,8 +285,6 @@ class VideoCapturer : public sigslot::has_slots<>,
// Returns true if format doesn't fulfill all applied restrictions.
bool ShouldFilterFormat(const VideoFormat& format) const;
- void UpdateStats(const CapturedFrame* captured_frame);
-
rtc::ThreadChecker thread_checker_;
std::string id_;
CaptureState capture_state_;
@@ -313,9 +307,6 @@ class VideoCapturer : public sigslot::has_slots<>,
rtc::CriticalSection frame_stats_crit_;
perkj_webrtc 2016/03/22 14:00:42 remove?
nisse-webrtc 2016/03/22 14:16:50 Done.
- // The captured frame format before potential adapation.
- VideoFormat last_captured_frame_format_;
-
// Whether capturer should apply rotation to the frame before signaling it.
bool apply_rotation_;
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/base/videocapturer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698