Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: webrtc/media/base/videosourceinterface.h

Issue 1766653002: Replace SetCapturer and SetCaptureDevice by SetSource. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Work-in-progress, after applying 1790633002. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 18 matching lines...) Expand all
29 // Tells the source the maximum number of pixels the sink wants. 29 // Tells the source the maximum number of pixels the sink wants.
30 rtc::Optional<int> max_pixel_count; 30 rtc::Optional<int> max_pixel_count;
31 // Like |max_pixel_count| but relative to the given value. The source is 31 // Like |max_pixel_count| but relative to the given value. The source is
32 // requested to produce frames with a resolution one "step up" from the given 32 // requested to produce frames with a resolution one "step up" from the given
33 // value. In practice, this means that the sink can consume this amount of 33 // value. In practice, this means that the sink can consume this amount of
34 // pixels but wants more and the source should produce a resolution one 34 // pixels but wants more and the source should produce a resolution one
35 // "step" higher than this but not higher. 35 // "step" higher than this but not higher.
36 rtc::Optional<int> max_pixel_count_step_up; 36 rtc::Optional<int> max_pixel_count_step_up;
37 }; 37 };
38 38
39 struct VideoSourceInfo {
40 // Original frame size, before video adaptation.
41 int orig_width = 0;
42 int orig_height = 0;
43 };
44
39 template <typename VideoFrameT> 45 template <typename VideoFrameT>
40 class VideoSourceInterface { 46 class VideoSourceInterface {
41 public: 47 public:
42 virtual void AddOrUpdateSink(VideoSinkInterface<VideoFrameT>* sink, 48 virtual void AddOrUpdateSink(VideoSinkInterface<VideoFrameT>* sink,
43 const VideoSinkWants& wants) = 0; 49 const VideoSinkWants& wants) = 0;
44 // RemoveSink must guarantee that at the time the method returns, 50 // RemoveSink must guarantee that at the time the method returns,
45 // there is no current and no future calls to VideoSinkInterface::OnFrame. 51 // there is no current and no future calls to VideoSinkInterface::OnFrame.
46 virtual void RemoveSink(VideoSinkInterface<VideoFrameT>* sink) = 0; 52 virtual void RemoveSink(VideoSinkInterface<VideoFrameT>* sink) = 0;
47 53 virtual void GetInfo(VideoSourceInfo *info) = 0;
perkj_webrtc 2016/03/20 15:01:46 So we have the option of adding some kind of stats
nisse-webrtc 2016/03/21 09:18:50 I've tried the third approach now. I like the simp
48 protected: 54 protected:
49 virtual ~VideoSourceInterface() {} 55 virtual ~VideoSourceInterface() {}
50 }; 56 };
51 57
52 } // namespace rtc 58 } // namespace rtc
53 #endif // WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 59 #endif // WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698