Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1766643002: Roll chromium_revision ee31124..508edd3 (378158:379249) (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
marpan2, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision ee31124..508edd3 (378158:379249) This includes renaming back libvpx_new to libvpx in https://codereview.chromium.org/1765703002 Add symlink to src/mojo as workaround while figuring out how to fix this upstream in Chromium. See webrtc:5629. Change log: https://chromium.googlesource.com/chromium/src/+log/ee31124..508edd3 Full diff: https://chromium.googlesource.com/chromium/src/+/ee31124..508edd3 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/6d49157..708db16 * src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/89cc682..None * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/a72f46e..df6e95e DEPS diff: https://chromium.googlesource.com/chromium/src/+/ee31124..508edd3/DEPS No update to Clang. BUG=webrtc:5629 TBR=marpan@webrtc.org, stefan@webrtc.org, NOTRY=True Committed: https://crrev.com/e26e78784b6a8798e6df59dc72ada47a0f2611ea Cr-Commit-Position: refs/heads/master@{#11879}

Patch Set 1 #

Patch Set 2 : Applied https://codereview.webrtc.org/1767473002/ #

Patch Set 3 : Added mojo symlink as workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M .gitignore View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M setup_links.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/webrtc.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
kjellander_webrtc
Filed webrtc:5629 for the mojo workaround. Hope to commit this now to unblock us.
4 years, 9 months ago (2016-03-04 12:53:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766643002/40001
4 years, 9 months ago (2016-03-04 12:53:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/1531)
4 years, 9 months ago (2016-03-04 13:14:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766643002/40001
4 years, 9 months ago (2016-03-04 22:22:42 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-04 22:39:33 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 22:39:39 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e26e78784b6a8798e6df59dc72ada47a0f2611ea
Cr-Commit-Position: refs/heads/master@{#11879}

Powered by Google App Engine
This is Rietveld 408576698