Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1766383002: Convert IntelligibilityEnhancer to multi-threaded mode (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index a7c120f3956b13f0c4a798a71f961453979dc213..e96f864672d7a3c4f20b37155dae562775e649dd 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -921,10 +921,6 @@ int AudioProcessingImpl::ProcessReverseStreamLocked() {
}
if (constants_.intelligibility_enabled) {
- // Currently run in single-threaded mode when the intelligibility
- // enhancer is activated.
- // TODO(peah): Fix to be properly multi-threaded.
- rtc::CritScope cs(&crit_capture_);
public_submodules_->intelligibility_enhancer->ProcessRenderAudio(
ra->split_channels_f(kBand0To8kHz), capture_nonlocked_.split_rate,
ra->num_channels());
@@ -1235,8 +1231,10 @@ void AudioProcessingImpl::InitializeBeamformer() {
void AudioProcessingImpl::InitializeIntelligibility() {
if (constants_.intelligibility_enabled) {
public_submodules_->intelligibility_enhancer.reset(
- new IntelligibilityEnhancer(capture_nonlocked_.split_rate,
- render_.render_audio->num_channels()));
+ new IntelligibilityEnhancer(
+ capture_nonlocked_.split_rate,
+ render_.render_audio->num_channels(),
+ public_submodules_->noise_suppression->num_noise_bins()));
turaj 2016/03/07 20:34:35 num_noise_bins() seemed could be declared static,
aluebs-webrtc 2016/03/08 10:53:00 Great point. Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698