Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

Issue 1765443002: Added log messages for important call setup events: first packet sent/received (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Corrected naming Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 RTC_DCHECK_GE(payload_length, rtp_header->header.paddingLength); 64 RTC_DCHECK_GE(payload_length, rtp_header->header.paddingLength);
65 const size_t payload_data_length = 65 const size_t payload_data_length =
66 payload_length - rtp_header->header.paddingLength; 66 payload_length - rtp_header->header.paddingLength;
67 67
68 if (payload == NULL || payload_data_length == 0) { 68 if (payload == NULL || payload_data_length == 0) {
69 return data_callback_->OnReceivedPayloadData(NULL, 0, rtp_header) == 0 ? 0 69 return data_callback_->OnReceivedPayloadData(NULL, 0, rtp_header) == 0 ? 0
70 : -1; 70 : -1;
71 } 71 }
72 72
73 if (first_packet_received_()) {
74 LOG(LS_INFO) << "Received first video RTP packet";
75 }
76
73 // We are not allowed to hold a critical section when calling below functions. 77 // We are not allowed to hold a critical section when calling below functions.
74 rtc::scoped_ptr<RtpDepacketizer> depacketizer( 78 rtc::scoped_ptr<RtpDepacketizer> depacketizer(
75 RtpDepacketizer::Create(rtp_header->type.Video.codec)); 79 RtpDepacketizer::Create(rtp_header->type.Video.codec));
76 if (depacketizer.get() == NULL) { 80 if (depacketizer.get() == NULL) {
77 LOG(LS_ERROR) << "Failed to create depacketizer."; 81 LOG(LS_ERROR) << "Failed to create depacketizer.";
78 return -1; 82 return -1;
79 } 83 }
80 84
81 rtp_header->type.Video.isFirstPacket = is_first_packet; 85 rtp_header->type.Video.isFirstPacket = is_first_packet;
82 RtpDepacketizer::ParsedPayload parsed_payload; 86 RtpDepacketizer::ParsedPayload parsed_payload;
(...skipping 30 matching lines...) Expand all
113 RtpFeedback* callback, 117 RtpFeedback* callback,
114 int8_t payload_type, 118 int8_t payload_type,
115 const char payload_name[RTP_PAYLOAD_NAME_SIZE], 119 const char payload_name[RTP_PAYLOAD_NAME_SIZE],
116 const PayloadUnion& specific_payload) const { 120 const PayloadUnion& specific_payload) const {
117 // TODO(pbos): Remove as soon as audio can handle a changing payload type 121 // TODO(pbos): Remove as soon as audio can handle a changing payload type
118 // without this callback. 122 // without this callback.
119 return 0; 123 return 0;
120 } 124 }
121 125
122 } // namespace webrtc 126 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698