Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/api/videotracksource.h

Issue 1765423005: Change VideoRtpReceiver to create remote VideoTrack and VideoTrackSource. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed up the comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/videotrack_unittest.cc ('k') | webrtc/api/videotracksource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/videotracksource.h
diff --git a/webrtc/api/videotracksource.h b/webrtc/api/videotracksource.h
index 59dae42950b9597d958190dc5e2c980646940263..5e2437c6b0d113f251f6332b8305c61e054eb47d 100644
--- a/webrtc/api/videotracksource.h
+++ b/webrtc/api/videotracksource.h
@@ -24,21 +24,27 @@ class VideoTrackSource : public Notifier<VideoTrackSourceInterface> {
VideoTrackSource(rtc::VideoSourceInterface<cricket::VideoFrame>* source,
rtc::Thread* worker_thread,
bool remote);
-
void SetState(SourceState new_state);
+ // OnSourceDestroyed clears this instance pointer to |source_|. It is useful
+ // when the underlying rtc::VideoSourceInterface is destroyed before the
+ // reference counted VideoTrackSource.
+ void OnSourceDestroyed();
+
SourceState state() const override { return state_; }
bool remote() const override { return remote_; }
void Stop() override{};
void Restart() override{};
- virtual bool is_screencast() const { return false; };
- virtual bool needs_denoising() const { return false; };
+ virtual bool is_screencast() const { return false; }
+ virtual bool needs_denoising() const { return false; }
void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
const rtc::VideoSinkWants& wants) override;
void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;
+ cricket::VideoCapturer* GetVideoCapturer() override { return nullptr; }
+
protected:
rtc::Thread* worker_thread() { return worker_thread_; }
« no previous file with comments | « webrtc/api/videotrack_unittest.cc ('k') | webrtc/api/videotracksource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698