Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1764623002: Remove the ID from AcmReceiver (Closed)

Created:
4 years, 9 months ago by hlundin-webrtc
Modified:
4 years, 9 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the ID from AcmReceiver This is an artifact from the past, and is no longer used. R=ivoc@webrtc.org Committed: https://crrev.com/0023fdffd0156d7cce71a0817e964689d6af762b Cr-Commit-Position: refs/heads/master@{#11866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 2 chunks +1 line, -7 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
hlundin-webrtc
PTAL
4 years, 9 months ago (2016-03-03 10:00:04 UTC) #1
ivoc
LGTM!
4 years, 9 months ago (2016-03-03 16:29:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764623002/1
4 years, 9 months ago (2016-03-03 16:34:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 9 months ago (2016-03-03 18:35:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764623002/1
4 years, 9 months ago (2016-03-03 18:40:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-03 20:40:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764623002/1
4 years, 9 months ago (2016-03-03 21:00:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-03 23:00:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764623002/1
4 years, 9 months ago (2016-03-04 07:03:44 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 07:05:43 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:05:51 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0023fdffd0156d7cce71a0817e964689d6af762b
Cr-Commit-Position: refs/heads/master@{#11866}

Powered by Google App Engine
This is Rietveld 408576698