Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 1764293002: Revert of Removed the inheritance from ProcessingComponent for EchoCancellerImpl. (Closed)

Created:
4 years, 9 months ago by The Sun (google.com)
Modified:
4 years, 9 months ago
Reviewers:
the sun, peah-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Removed the inheritance from ProcessingComponent for EchoCancellerImpl. (patchset #4 id:60001 of https://codereview.webrtc.org/1761813002/ ) Reason for revert: Breaks all bots, e.g. https://uberchromegw.corp.google.com/i/client.webrtc/builders/Android32%20Builder/builds/6356/steps/compile/logs/stdio Looks like a missing rebase before landing. Resolve and try again. Original issue's description: > Removed the inheritance from ProcessingComponent for EchoCancellerImpl. > > BUG=webrtc:5352 > > Committed: https://crrev.com/3af0a009f8a7f2dfb630a4f4730044cbbd95bee8 > Cr-Commit-Position: refs/heads/master@{#11876} TBR=solenberg@webrtc.org,peah@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5352 Committed: https://crrev.com/92586f08e532105220425102ac3f355d66d5d387 Cr-Commit-Position: refs/heads/master@{#11877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -120 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 8 chunks +8 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 7 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 17 chunks +71 lines, -93 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
The Sun (google.com)
Created Revert of Removed the inheritance from ProcessingComponent for EchoCancellerImpl.
4 years, 9 months ago (2016-03-04 20:28:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764293002/1
4 years, 9 months ago (2016-03-04 20:28:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 20:29:06 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 20:29:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92586f08e532105220425102ac3f355d66d5d387
Cr-Commit-Position: refs/heads/master@{#11877}

Powered by Google App Engine
This is Rietveld 408576698