Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: webrtc/video/video_capture_input.h

Issue 1763693002: Move encoder thread to VideoSendStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/video/video_capture_input.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_capture_input.h
diff --git a/webrtc/video/video_capture_input.h b/webrtc/video/video_capture_input.h
index be265bf9a827c930369fb185c2201f3470cf50be..90d7a316a2e53a2afcc47a0af3b13609764e6df2 100644
--- a/webrtc/video/video_capture_input.h
+++ b/webrtc/video/video_capture_input.h
@@ -34,17 +34,10 @@ class OveruseFrameDetector;
class SendStatisticsProxy;
class VideoRenderer;
-class VideoCaptureCallback {
- public:
- virtual ~VideoCaptureCallback() {}
-
- virtual void DeliverFrame(VideoFrame video_frame) = 0;
-};
-
namespace internal {
class VideoCaptureInput : public webrtc::VideoCaptureInput {
public:
- VideoCaptureInput(VideoCaptureCallback* frame_callback,
+ VideoCaptureInput(rtc::Event* capture_event,
VideoRenderer* local_renderer,
SendStatisticsProxy* send_stats_proxy,
OveruseFrameDetector* overuse_detector);
@@ -52,21 +45,14 @@ class VideoCaptureInput : public webrtc::VideoCaptureInput {
void IncomingCapturedFrame(const VideoFrame& video_frame) override;
- private:
- // Thread functions for deliver captured frames to receivers.
- static bool EncoderThreadFunction(void* obj);
- bool EncoderProcess();
+ bool GetVideoFrame(VideoFrame* frame);
+ private:
rtc::CriticalSection crit_;
- VideoCaptureCallback* const frame_callback_;
VideoRenderer* const local_renderer_;
SendStatisticsProxy* const stats_proxy_;
-
- rtc::PlatformThread encoder_thread_;
- rtc::Event capture_event_;
-
- volatile int stop_;
+ rtc::Event* const capture_event_;
VideoFrame captured_frame_ GUARDED_BY(crit_);
Clock* const clock_;
« no previous file with comments | « no previous file | webrtc/video/video_capture_input.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698