Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1762863002: Renaming variables in p2ptransportchannel to be consistent. (Closed)

Created:
4 years, 9 months ago by honghaiz3
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, guoweis_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renaming variables in p2ptransportchannel to be consistent. Also change the type of "time interval" to int from uint32. Fixed a few TODO therein. I think we should have the following convention: 1. All time delay/intervals should have type int although the time instant should have time uint32_t. 2. "interval" is preferred to "delay" if the delay will be repeated (like rescheduling). BUG= R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/049fbb1883344dd32081bf6ae02012aef927eaea

Patch Set 1 : #

Patch Set 2 : Merge with head #

Patch Set 3 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -70 lines) Patch
M webrtc/api/webrtcsession.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 4 chunks +9 lines, -7 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 2 7 chunks +40 lines, -38 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
honghaiz3
4 years, 9 months ago (2016-03-03 22:55:47 UTC) #6
pthatcher1
lgtm
4 years, 9 months ago (2016-03-05 01:33:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762863002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762863002/100001
4 years, 9 months ago (2016-03-07 18:21:37 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/049fbb1883344dd32081bf6ae02012aef927eaea Cr-Commit-Position: refs/heads/master@{#11888}
4 years, 9 months ago (2016-03-07 19:13:19 UTC) #14
honghaiz3
4 years, 9 months ago (2016-03-07 19:13:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:100001) manually as
049fbb1883344dd32081bf6ae02012aef927eaea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698