Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1762003003: If MSID is encoded in both ways, make the SSRC-level one take priority. (Closed)

Created:
4 years, 9 months ago by Taylor Brandstetter
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

If MSID is encoded in both ways, make the SSRC-level one take priority. BUG=webrtc:5264 R=pthatcher@webrtc.org Committed: https://crrev.com/5de6b753bdbdb572807cf2ec9d3923f471b8f950 Cr-Commit-Position: refs/heads/master@{#11933}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -25 lines) Patch
M webrtc/api/webrtcsdp.cc View 1 4 chunks +29 lines, -25 lines 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 1 2 chunks +99 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Taylor Brandstetter
4 years, 9 months ago (2016-03-03 21:05:11 UTC) #2
pthatcher1
Should we have unit tests? https://codereview.webrtc.org/1762003003/diff/1/webrtc/api/webrtcsdp.cc File webrtc/api/webrtcsdp.cc (right): https://codereview.webrtc.org/1762003003/diff/1/webrtc/api/webrtcsdp.cc#newcode576 webrtc/api/webrtcsdp.cc:576: const std::string &msid_track_id, Put ...
4 years, 9 months ago (2016-03-05 01:30:15 UTC) #3
Taylor Brandstetter
Unit test added. https://codereview.webrtc.org/1762003003/diff/1/webrtc/api/webrtcsdp.cc File webrtc/api/webrtcsdp.cc (right): https://codereview.webrtc.org/1762003003/diff/1/webrtc/api/webrtcsdp.cc#newcode576 webrtc/api/webrtcsdp.cc:576: const std::string &msid_track_id, On 2016/03/05 01:30:15, ...
4 years, 9 months ago (2016-03-08 02:23:21 UTC) #4
pthatcher1
lgtm
4 years, 9 months ago (2016-03-08 17:51:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762003003/20001
4 years, 9 months ago (2016-03-09 22:12:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/9609)
4 years, 9 months ago (2016-03-09 23:10:04 UTC) #9
Taylor Brandstetter
Committed patchset #2 (id:20001) manually as 5de6b753bdbdb572807cf2ec9d3923f471b8f950 (presubmit successful).
4 years, 9 months ago (2016-03-10 01:02:45 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5de6b753bdbdb572807cf2ec9d3923f471b8f950 Cr-Commit-Position: refs/heads/master@{#11933}
4 years, 9 months ago (2016-03-10 01:02:48 UTC) #13
perkj_webrtc
On 2016/03/10 01:02:48, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 9 months ago (2016-03-10 14:29:43 UTC) #14
Taylor Brandstetter
4 years, 9 months ago (2016-03-10 17:23:25 UTC) #15
Message was sent while issue was closed.
On 2016/03/10 14:29:43, perkj_webrtc wrote:
> On 2016/03/10 01:02:48, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/5de6b753bdbdb572807cf2ec9d3923f471b8f950
> > Cr-Commit-Position: refs/heads/master@{#11933}
> 
> wrong bug number?

Yep, sorry. Should have been 5624.

Powered by Google App Engine
This is Rietveld 408576698