Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 1761813002: Removed the inheritance from ProcessingComponent for EchoCancellerImpl. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Corrected a bad merge Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_
12 #define WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_ 12 #define WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_
13 13
14 #include <memory> 14 #include <memory>
15 15
16 #include "webrtc/base/constructormagic.h"
16 #include "webrtc/base/criticalsection.h" 17 #include "webrtc/base/criticalsection.h"
17 #include "webrtc/common_audio/swap_queue.h" 18 #include "webrtc/common_audio/swap_queue.h"
18 #include "webrtc/modules/audio_processing/include/audio_processing.h" 19 #include "webrtc/modules/audio_processing/include/audio_processing.h"
19 #include "webrtc/modules/audio_processing/processing_component.h" 20 #include "webrtc/modules/audio_processing/processing_component.h"
20 21
21 namespace webrtc { 22 namespace webrtc {
22 23
23 class AudioBuffer; 24 class AudioBuffer;
24 25
25 class EchoCancellationImpl : public EchoCancellation, 26 class EchoCancellationImpl : public EchoCancellation {
26 public ProcessingComponent {
27 public: 27 public:
28 EchoCancellationImpl(const AudioProcessing* apm, 28 EchoCancellationImpl(const AudioProcessing* apm,
29 rtc::CriticalSection* crit_render, 29 rtc::CriticalSection* crit_render,
30 rtc::CriticalSection* crit_capture); 30 rtc::CriticalSection* crit_capture);
31 virtual ~EchoCancellationImpl(); 31 virtual ~EchoCancellationImpl();
32 32
33 int ProcessRenderAudio(const AudioBuffer* audio); 33 int ProcessRenderAudio(const AudioBuffer* audio);
34 int ProcessCaptureAudio(AudioBuffer* audio); 34 int ProcessCaptureAudio(AudioBuffer* audio);
35 35
36 // EchoCancellation implementation. 36 // EchoCancellation implementation.
37 bool is_enabled() const override; 37 bool is_enabled() const override;
38 int stream_drift_samples() const override; 38 int stream_drift_samples() const override;
39 SuppressionLevel suppression_level() const override; 39 SuppressionLevel suppression_level() const override;
40 bool is_drift_compensation_enabled() const override; 40 bool is_drift_compensation_enabled() const override;
41 41
42 // ProcessingComponent implementation. 42 void Initialize();
43 int Initialize() override; 43 void SetExtraOptions(const Config& config);
44 void SetExtraOptions(const Config& config) override;
45 bool is_delay_agnostic_enabled() const; 44 bool is_delay_agnostic_enabled() const;
46 bool is_extended_filter_enabled() const; 45 bool is_extended_filter_enabled() const;
47 bool is_next_generation_aec_enabled() const; 46 bool is_next_generation_aec_enabled() const;
48 47
49 // Reads render side data that has been queued on the render call. 48 // Reads render side data that has been queued on the render call.
50 // Called holding the capture lock. 49 // Called holding the capture lock.
51 void ReadQueuedRenderData(); 50 void ReadQueuedRenderData();
52 51
53 // Returns the system delay of the first AEC component. 52 // Returns the system delay of the first AEC component.
54 int GetSystemDelayInSamples() const; 53 int GetSystemDelayInSamples() const;
55 54
56 private: 55 private:
56 class Canceller;
57
57 // EchoCancellation implementation. 58 // EchoCancellation implementation.
58 int Enable(bool enable) override; 59 int Enable(bool enable) override;
59 int enable_drift_compensation(bool enable) override; 60 int enable_drift_compensation(bool enable) override;
60 void set_stream_drift_samples(int drift) override; 61 void set_stream_drift_samples(int drift) override;
61 int set_suppression_level(SuppressionLevel level) override; 62 int set_suppression_level(SuppressionLevel level) override;
62 int enable_metrics(bool enable) override; 63 int enable_metrics(bool enable) override;
63 bool are_metrics_enabled() const override; 64 bool are_metrics_enabled() const override;
64 bool stream_has_echo() const override; 65 bool stream_has_echo() const override;
65 int GetMetrics(Metrics* metrics) override; 66 int GetMetrics(Metrics* metrics) override;
66 int enable_delay_logging(bool enable) override; 67 int enable_delay_logging(bool enable) override;
67 bool is_delay_logging_enabled() const override; 68 bool is_delay_logging_enabled() const override;
68 int GetDelayMetrics(int* median, int* std) override; 69 int GetDelayMetrics(int* median, int* std) override;
69 int GetDelayMetrics(int* median, 70 int GetDelayMetrics(int* median,
70 int* std, 71 int* std,
71 float* fraction_poor_delays) override; 72 float* fraction_poor_delays) override;
72 73
73 struct AecCore* aec_core() const override; 74 struct AecCore* aec_core() const override;
74 75
75 // ProcessingComponent implementation. 76 size_t num_handles_required() const;
76 void* CreateHandle() const override;
77 int InitializeHandle(void* handle) const override;
78 int ConfigureHandle(void* handle) const override;
79 void DestroyHandle(void* handle) const override;
80 size_t num_handles_required() const override;
81 int GetHandleError(void* handle) const override;
82 77
83 void AllocateRenderQueue(); 78 void AllocateRenderQueue();
79 int Configure();
84 80
85 // Not guarded as its public API is thread safe. 81 // Not guarded as its public API is thread safe.
86 const AudioProcessing* apm_; 82 const AudioProcessing* apm_;
87 83
88 rtc::CriticalSection* const crit_render_ ACQUIRED_BEFORE(crit_capture_); 84 rtc::CriticalSection* const crit_render_ ACQUIRED_BEFORE(crit_capture_);
89 rtc::CriticalSection* const crit_capture_; 85 rtc::CriticalSection* const crit_capture_;
90 86
87 bool enabled_ = false;
91 bool drift_compensation_enabled_ GUARDED_BY(crit_capture_); 88 bool drift_compensation_enabled_ GUARDED_BY(crit_capture_);
92 bool metrics_enabled_ GUARDED_BY(crit_capture_); 89 bool metrics_enabled_ GUARDED_BY(crit_capture_);
93 SuppressionLevel suppression_level_ GUARDED_BY(crit_capture_); 90 SuppressionLevel suppression_level_ GUARDED_BY(crit_capture_);
94 int stream_drift_samples_ GUARDED_BY(crit_capture_); 91 int stream_drift_samples_ GUARDED_BY(crit_capture_);
95 bool was_stream_drift_set_ GUARDED_BY(crit_capture_); 92 bool was_stream_drift_set_ GUARDED_BY(crit_capture_);
96 bool stream_has_echo_ GUARDED_BY(crit_capture_); 93 bool stream_has_echo_ GUARDED_BY(crit_capture_);
97 bool delay_logging_enabled_ GUARDED_BY(crit_capture_); 94 bool delay_logging_enabled_ GUARDED_BY(crit_capture_);
98 bool extended_filter_enabled_ GUARDED_BY(crit_capture_); 95 bool extended_filter_enabled_ GUARDED_BY(crit_capture_);
99 bool delay_agnostic_enabled_ GUARDED_BY(crit_capture_); 96 bool delay_agnostic_enabled_ GUARDED_BY(crit_capture_);
100 bool next_generation_aec_enabled_ GUARDED_BY(crit_capture_); 97 bool next_generation_aec_enabled_ GUARDED_BY(crit_capture_);
101 98
102 size_t render_queue_element_max_size_ GUARDED_BY(crit_render_) 99 size_t render_queue_element_max_size_ GUARDED_BY(crit_render_)
103 GUARDED_BY(crit_capture_); 100 GUARDED_BY(crit_capture_);
104 std::vector<float> render_queue_buffer_ GUARDED_BY(crit_render_); 101 std::vector<float> render_queue_buffer_ GUARDED_BY(crit_render_);
105 std::vector<float> capture_queue_buffer_ GUARDED_BY(crit_capture_); 102 std::vector<float> capture_queue_buffer_ GUARDED_BY(crit_capture_);
106 103
107 // Lock protection not needed. 104 // Lock protection not needed.
108 std::unique_ptr<SwapQueue<std::vector<float>, RenderQueueItemVerifier<float>>> 105 std::unique_ptr<SwapQueue<std::vector<float>, RenderQueueItemVerifier<float>>>
109 render_signal_queue_; 106 render_signal_queue_;
107
108 std::vector<std::unique_ptr<Canceller>> cancellers_;
109 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(EchoCancellationImpl);
110 }; 110 };
111 111
112 } // namespace webrtc 112 } // namespace webrtc
113 113
114 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_ 114 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/echo_cancellation_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698