Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1759503002: Add android specific audio mute function. (Closed)

Created:
4 years, 9 months ago by AlexG
Modified:
4 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 1 5 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
henrika_webrtc
LGTM assuming that it will not be used as a temporary solution. https://codereview.webrtc.org/1759503002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java ...
4 years, 9 months ago (2016-03-02 08:49:34 UTC) #2
AlexG
https://codereview.webrtc.org/1759503002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java (right): https://codereview.webrtc.org/1759503002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java#newcode276 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:276: microphoneMute = mute; On 2016/03/02 08:49:34, henrika_webrtc wrote: > ...
4 years, 9 months ago (2016-03-02 18:52:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759503002/20001
4 years, 9 months ago (2016-03-02 18:55:00 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4aee2a928fb52fd6222846857d55630ceda52751 Cr-Commit-Position: refs/heads/master@{#11849}
4 years, 9 months ago (2016-03-02 21:02:15 UTC) #9
AlexG
4 years, 9 months ago (2016-03-02 21:02:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4aee2a928fb52fd6222846857d55630ceda52751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698