Removed VideoSource dependency to ChannelManager.

Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the worker_thread.

Document: https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8Tlwn9JGvhbUjVpY/edit?usp=sharing

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/0f13ec1265250a87a5390c9a0403943bcf1bbf33

[perkj_webrtc, 2016-03-02 15:06:05]

Description was changed from

==========
Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the
worker_thread.

BUG=
==========

to

==========
Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the
worker_thread.

Document:
https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8...
 

BUG=webrtc:5426
==========

[perkj_webrtc, 2016-03-02 15:42:24]

perkj@webrtc.org changed reviewers:
+ nisse@webrtc.org, pthatcher@webrtc.org

[perkj_webrtc, 2016-03-02 15:42:25]

Please?
This is the first cl made from https://codereview.webrtc.org/1749013003/

[pthatcher1, 2016-03-02 20:12:53]

lgtm

[nisse-webrtc, 2016-03-03 07:56:27]

lgtm

So OnStageChange is called on the signalling thread, and everything else on the
worker thread?

https://codereview.webrtc.org/1759473003/diff/1/webrtc/api/videosource.h
File webrtc/api/videosource.h (left):

https://codereview.webrtc.org/1759473003/diff/1/webrtc/api/videosource.h#oldc...
webrtc/api/videosource.h:89:
std::list<rtc::VideoSinkInterface<cricket::VideoFrame>*> sinks_;
The sink list is now only in the capturer, right?

[perkj_webrtc, 2016-03-03 08:06:30]

On 2016/03/03 07:56:27, nisse-webrtc wrote:
> lgtm
> 
> So OnStageChange is called on the signalling thread, and everything else on
the
> worker thread?
> 

OnStateChange is a callback from a cricket::VideoCapturer and it will be invoked
on the worker thread. But the VideoSource is accessed on the signaling thread
and marshalls the OnStateChange callback to the signaling thread.  

> https://codereview.webrtc.org/1759473003/diff/1/webrtc/api/videosource.h
> File webrtc/api/videosource.h (left):
> 
>
https://codereview.webrtc.org/1759473003/diff/1/webrtc/api/videosource.h#oldc...
> webrtc/api/videosource.h:89:
> std::list<rtc::VideoSinkInterface<cricket::VideoFrame>*> sinks_;
> The sink list is now only in the capturer, right?

[perkj_webrtc, 2016-03-03 08:06:55]

https://codereview.webrtc.org/1759473003/diff/1/webrtc/api/videosource.h
File webrtc/api/videosource.h (left):

https://codereview.webrtc.org/1759473003/diff/1/webrtc/api/videosource.h#oldc...
webrtc/api/videosource.h:89:
std::list<rtc::VideoSinkInterface<cricket::VideoFrame>*> sinks_;
On 2016/03/03 07:56:27, nisse-webrtc wrote:
> The sink list is now only in the capturer, right?

right

[perkj_webrtc, 2016-03-03 08:07:51]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-03-03 08:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1759473003/#ps20001 (title:
"Fix problem that Stop could be called mulptiple times.")

[commit-bot: I haz the power, 2016-03-03 08:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1759473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1759473003/20001

[commit-bot: I haz the power, 2016-03-03 08:22:45]

Description was changed from

==========
Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the
worker_thread.

Document:
https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8...
 

BUG=webrtc:5426
==========

to

==========
Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the
worker_thread.

Document:
https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8...

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/0f13ec1265250a87a5390c9a0403943bcf1bbf33
Cr-Commit-Position: refs/heads/master@{#11852}
==========

[commit-bot: I haz the power, 2016-03-03 08:22:46]

Patchset 2 (id:??) landed as
https://crrev.com/0f13ec1265250a87a5390c9a0403943bcf1bbf33
Cr-Commit-Position: refs/heads/master@{#11852}

[perkj_webrtc, 2016-03-03 08:22:46]

Description was changed from

==========
Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the
worker_thread.

Document:
https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8...

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/0f13ec1265250a87a5390c9a0403943bcf1bbf33
Cr-Commit-Position: refs/heads/master@{#11852}
==========

to

==========
Removed VideoSource dependency to ChannelManager.
Instead VideoSource directly access the cricket::VideoCapturer via the
worker_thread.

Document:
https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8...

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/0f13ec1265250a87a5390c9a0...
==========

[perkj_webrtc, 2016-03-03 08:22:48]

Committed patchset #2 (id:20001) manually as
0f13ec1265250a87a5390c9a0403943bcf1bbf33 (presubmit successful).