Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1758603003: Move RTP module send status outside of ViEChannel. (Closed)

Created:
4 years, 9 months ago by pbos-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTP module send status outside of ViEChannel. Removes StartSend, StopSend and SetSendCodec from ViEChannel and into VideoSendStream which uses the payload router to configure them directly. BUG=webrtc:5494 R=stefan@webrtc.org Committed: https://crrev.com/0a9fc05583c15438ca381498ee2db1da718c0c57 Cr-Commit-Position: refs/heads/master@{#11845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -75 lines) Patch
M webrtc/video/video_send_stream.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M webrtc/video/vie_channel.h View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/video/vie_channel.cc View 2 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL, woo!
4 years, 9 months ago (2016-03-02 14:16:23 UTC) #1
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-02 14:34:43 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 0a9fc05583c15438ca381498ee2db1da718c0c57 (presubmit successful).
4 years, 9 months ago (2016-03-02 15:24:26 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 15:24:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a9fc05583c15438ca381498ee2db1da718c0c57
Cr-Commit-Position: refs/heads/master@{#11845}

Powered by Google App Engine
This is Rietveld 408576698