Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1758223002: Change webrtc::VideoSourceInterface to inherit rtc::VideoSourceInterface. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change webrtc::VideoSourceInterface to inherit rtc::VideoSourceInterface. Also introduce a typedef VideoTrackSourceInterface to be able to start changing clients such as Chrome to use the name VideoTrackSourceInterface. Document: https://docs.google.com/a/google.com/document/d/1mEIw_0uDzyHjL3l8a82WKp6AvgR8Tlwn9JGvhbUjVpY/edit?usp=sharing BUG=webrtc:5426 Committed: https://crrev.com/f2880a0e04fdea1710976d1ae170379907028d1b Cr-Commit-Position: refs/heads/master@{#11854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -42 lines) Patch
M webrtc/api/rtpsenderreceiver_unittest.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M webrtc/api/videosource.h View 2 chunks +3 lines, -11 lines 0 comments Download
M webrtc/api/videosource.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/api/videosource_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/videosourceinterface.h View 2 chunks +8 lines, -11 lines 0 comments Download
M webrtc/api/videosourceproxy.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/videotrack.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videosourceinterface.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_webrtc
please?
4 years, 9 months ago (2016-03-03 08:59:32 UTC) #2
nisse-webrtc
lgtm I would have expected this to be a little harder.
4 years, 9 months ago (2016-03-03 09:26:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758223002/1
4 years, 9 months ago (2016-03-03 09:35:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 09:51:56 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 09:52:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2880a0e04fdea1710976d1ae170379907028d1b
Cr-Commit-Position: refs/heads/master@{#11854}

Powered by Google App Engine
This is Rietveld 408576698