Make sure rotation is not applied by the capturer if the CVO exenstion is set before the send strea…

Make sure rotation is not applied by the capturer if the CVO exenstion is set before the send stream is created.

BUG=webrtc:5621
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/91e1c15f8ee52f9c0a2fff2516d929d7ad594f97
Cr-Commit-Position: refs/heads/master@{#11841}

[perkj_webrtc, 2016-03-02 10:53:33]

perkj@webrtc.org changed reviewers:
+ pbos@webrtc.org, pthatcher@webrtc.org

[perkj_webrtc, 2016-03-02 10:53:33]

Please? 
I would like to keep this cl small if I have to merge it. 
Do you know if Chrome ever provide frames with rotation !=0 ?

[pbos-webrtc, 2016-03-02 10:54:07]

Description was changed from

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc::5621
==========

to

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621
==========

[perkj_webrtc, 2016-03-02 10:55:57]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 10:56:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757853002/1

[pbos-webrtc, 2016-03-02 10:57:09]

lgtm

I only see kVideoRotation_0 in:

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

[commit-bot: I haz the power, 2016-03-02 11:50:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 11:50:57]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2016-03-02 13:31:24]

Description was changed from

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621
==========

to

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621

TBR=pthatcher@webrtc.org
==========

[perkj_webrtc, 2016-03-02 13:31:47]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-03-02 13:31:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757853002/1

[commit-bot: I haz the power, 2016-03-02 13:34:04]

Description was changed from

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621

TBR=pthatcher@webrtc.org
==========

to

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621

TBR=pthatcher@webrtc.org
==========

[commit-bot: I haz the power, 2016-03-02 13:34:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-02 13:34:15]

Description was changed from

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621

TBR=pthatcher@webrtc.org
==========

to

==========
Make sure rotation is not applied by the capturer if the CVO exenstion is set
before the send stream is created.

BUG=webrtc:5621

TBR=pthatcher@webrtc.org

Committed: https://crrev.com/91e1c15f8ee52f9c0a2fff2516d929d7ad594f97
Cr-Commit-Position: refs/heads/master@{#11841}
==========

[commit-bot: I haz the power, 2016-03-02 13:34:16]

Patchset 1 (id:??) landed as
https://crrev.com/91e1c15f8ee52f9c0a2fff2516d929d7ad594f97
Cr-Commit-Position: refs/heads/master@{#11841}

[pthatcher1, 2016-03-02 20:08:27]

lgtm

I believe Chrome does not *send* with the header extension, only Android and
maybe iOS mobile apps.

But Chrome should be able to *receive* the header extension from such a mobile
app.

As long as the bug only broke sending and not receiving of the header extension
(which I believe is the case), then we don't need to DI into a previous cut of
Chrome.