Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1757843003: Remove CaptureManager and related calls in ChannelManager. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove CaptureManager and related calls in ChannelManager. Removed unused screencast APIs. BUG=webrtc:5426 Committed: https://crrev.com/c11b18483749b7f37559221b8401d24b9f5229f5 Cr-Commit-Position: refs/heads/master@{#11896}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -881 lines) Patch
M webrtc/api/webrtcsession_unittest.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/base/capturemanager.h View 1 chunk +1 line, -71 lines 0 comments Download
M webrtc/media/base/capturemanager.cc View 1 chunk +1 line, -287 lines 0 comments Download
D webrtc/media/base/capturemanager_unittest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D webrtc/media/base/fakecapturemanager.h View 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/media/media_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/pc/channel.h View 1 6 chunks +3 lines, -26 lines 0 comments Download
M webrtc/pc/channel.cc View 7 chunks +1 line, -113 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M webrtc/pc/channelmanager.h View 6 chunks +1 line, -40 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 6 chunks +3 lines, -111 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
perkj_webrtc
Are we getting closer to celebrate?
4 years, 9 months ago (2016-03-03 10:39:44 UTC) #3
pthatcher1
lgtm And yes, we should do some celebration
4 years, 9 months ago (2016-03-05 01:31:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757843003/20001
4 years, 9 months ago (2016-03-07 16:47:11 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
4 years, 9 months ago (2016-03-07 16:49:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757843003/40001
4 years, 9 months ago (2016-03-08 00:25:24 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 01:34:17 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 01:35:52 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c11b18483749b7f37559221b8401d24b9f5229f5
Cr-Commit-Position: refs/heads/master@{#11896}

Powered by Google App Engine
This is Rietveld 408576698